From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefano babic Date: Sat, 11 Aug 2012 23:57:48 +0200 Subject: [U-Boot] [PATCH] fsl_esdhc: Add no-snoop config for default init In-Reply-To: <746717980.2303098.1344707942239.JavaMail.root@advansee.com> References: <746717980.2303098.1344707942239.JavaMail.root@advansee.com> Message-ID: <5026D55C.50906@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 11/08/2012 19:59, schrieb Beno?t Th?baudeau: > Hi Stefano, > Hi Beno?t, > That could be a solution. However, that would have to be done for i.MX25 and > i.MX35 too (I have patches to add/fix eSDHC support for these that I will post > shortly), which means more duplicated code that should rather be centralized > somewhere. Ok, I'll wait for your patches ;-) > >>> On i.MX, the patch could also be improved by not making this option >>> available, >>> but behaving as if it were set. >> >> Right. It should not be configurable. We know that the i.MXs have no >> snoop cabability. > > The solution I would like would be to have some automatic ARCH_IMX (or ARCH_MXC) > config like on Linux. Then the fsl_esdhc driver could use this config to remove > all cache snooping stuff from its code and from struct fsl_esdhc_cfg. > > The i.MX board files would have to be updated to no longer refer to the no_snoop > field. struct fsl_esdhc_cfg would then have only one field for i.MX, but this is > not really an issue. Yes, this is no an issue. > > ARCH_IMX could be defined in all imx-regs.h files. Or the fsl_esdhc driver could > simply use a #if testing all the supported CONFIG_MX*. Let the fsl_edhc checking for CONFIG_MX* results clear for us today, but nobody will remember after some times and if the checked CONFIG_MX* will be changed, it will have drawbacks not so evident on MMC. I prefer the first solution, adding an entry to imx-regs.h. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================