public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] Consolidate bootcount code into drivers/bootcount
Date: Mon, 13 Aug 2012 15:37:28 +0200	[thread overview]
Message-ID: <50290318.7080305@denx.de> (raw)
In-Reply-To: <5028FD1A.5010608@gmail.com>

Hi Andreas,

On 08/13/2012 03:11 PM, Andreas Bie?mann wrote:
>> +LIB 	:= $(obj)libbootcount.o
>> +
>> +COBJS-y				+= bootcount.o
>> +COBJS-$(CONFIG_AT91SAM9XE)	+= bootcount_at91.o
> 
> I tend to NAK this. Before it was available to all at91 processors (keep
> in mind nearly all at91 have this gpbr register). Now it is only
> available to AT91SAM9XE processor series which is the only user for
> bootcount in mainline.

Then we should choose a different CONFIG_ option here. One that selects
all AT91 boards potentially supporting this feature. You are the expert
here, please make a suggestion.

> I fear we may break some not mainline boards
> here.

Maybe. But we usually don't care about out-of-tree ports.

> I would prefer something that includes all different at91 SoC by
> default (except rm9200).
> 
> I have no solution yet but send this to prevent a v4. Will send a
> proposal for at91 later this day.

Okay. But I would really like to see this patch go in soon. I still have
a new board support patch waiting here for quite a long time depending
on this bootcount stuff.

Best regards,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2012-08-13 13:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05  6:37 [U-Boot] [PATCH v3] Consolidate bootcount code into drivers/bootcount Stefan Roese
2012-06-05 12:19 ` Rob Herring
2012-08-10 20:32 ` Wolfgang Denk
2012-08-11 16:20 ` Mike Frysinger
2012-08-13  9:46   ` Stefan Roese
2012-08-13 13:11 ` Andreas Bießmann
2012-08-13 13:37   ` Stefan Roese [this message]
2012-08-13 13:48     ` Andreas Bießmann
2012-08-13 14:51       ` Stefan Roese
2012-08-13 15:04         ` Andreas Bießmann
  -- strict thread matches above, loose matches on Subject: below --
2012-08-13 11:56 [U-Boot] [PATCH v4] " Stefan Roese
2012-08-13 16:05 ` [U-Boot] [PATCH v3] " Christian Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50290318.7080305@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox