From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] nand_spl: change out_be32 to raw_writel and depend on subsequent sync
Date: Mon, 13 Aug 2012 18:34:42 -0500 [thread overview]
Message-ID: <50298F12.7060807@freescale.com> (raw)
In-Reply-To: <CAEsOVNcShJ7J_AP36jxoCCpLA4nBfdBrF75OgLJY9ZtBvWrt0A@mail.gmail.com>
On 08/13/2012 06:31 PM, McClintock Matthew-B29882 wrote:
> On Mon, Aug 13, 2012 at 6:23 PM, Scott Wood <scottwood@freescale.com> wrote:
>> On 08/13/2012 01:10 PM, Matthew McClintock wrote:
>>> This change reduces the SPL size by removing the redundant syncs produced
>>> by out_be32 and just replies on one final sync
>>>
>>> Done with:
>>>
>>> sed -r '/in_be32/b; s/(out_be32)\(([^,]*),\s+(.*)\)/__raw_writel(\3, \2)/g' -i `git grep --name-only sdram_init nand_spl/`
>>>
>>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>>> ---
>>> nand_spl/board/freescale/p1010rdb/nand_boot.c | 54 ++++++++++-----------
>>> nand_spl/board/freescale/p1023rds/nand_boot.c | 42 ++++++++--------
>>> nand_spl/board/freescale/p1_p2_rdb_pc/nand_boot.c | 48 +++++++++---------
>>> 3 files changed, 71 insertions(+), 73 deletions(-)
>>
>> This should come first if the other patches break without it, to
>> preserve bisectability.
>
> I think they all work on at least some compilers.... not that that's
> extremely helpful.
Was this patch meant to free up room for the other patches, or was it
just bundled in because it's touching the same code?
-Scott
next prev parent reply other threads:[~2012-08-13 23:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 18:10 [U-Boot] [PATCH 1/6] p1014rdb: set ddr bus width properly depending on SVR Matthew McClintock
2012-08-13 18:10 ` [U-Boot] [PATCH 2/6] p1010rdb: fix ddr values for p1014rdb (setting bus width to 16bit) Matthew McClintock
2012-08-13 18:10 ` [U-Boot] [PATCH 3/6] powerpc/p1010rdb: nandboot: compare SVR properly Matthew McClintock
2012-08-13 18:10 ` [U-Boot] [PATCH 4/6] nand_spl: update udelay for Freescale boards Matthew McClintock
2012-08-13 22:56 ` Scott Wood
2012-08-13 23:14 ` McClintock Matthew-B29882
2012-08-13 23:22 ` Scott Wood
2012-08-13 23:28 ` McClintock Matthew-B29882
2012-08-13 23:35 ` Scott Wood
2012-08-13 18:10 ` [U-Boot] [PATCH 5/6] nand_spl: p1023rds: wait before enabling DDR controller Matthew McClintock
2012-08-13 18:18 ` Scott Wood
2012-08-13 18:50 ` McClintock Matthew-B29882
2012-08-13 18:10 ` [U-Boot] [PATCH 6/6] nand_spl: change out_be32 to raw_writel and depend on subsequent sync Matthew McClintock
2012-08-13 23:23 ` Scott Wood
2012-08-13 23:31 ` McClintock Matthew-B29882
2012-08-13 23:34 ` Scott Wood [this message]
2012-08-13 23:37 ` McClintock Matthew-B29882
2012-08-18 19:05 ` Scott Wood
2012-08-20 16:11 ` Andy Fleming
2012-08-20 16:51 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50298F12.7060807@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox