From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 14 Aug 2012 11:25:35 +0200 Subject: [U-Boot] [PATCH 03/13] spl mxc nand: Merge duplicated code In-Reply-To: <1413177045.2374986.1344890936074.JavaMail.root@advansee.com> References: <1413177045.2374986.1344890936074.JavaMail.root@advansee.com> Message-ID: <502A198F.1040001@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 13/08/2012 22:48, Beno?t Th?baudeau wrote: > Merge duplicated code into functions, which is better for SPL size too. > > Signed-off-by: Beno?t Th?baudeau > Cc: Scott Wood > Cc: Stefano Babic > --- Hi Beno?t, > .../nand_spl/nand_boot_fsl_nfc.c | 50 +++++++++----------- > 1 file changed, 23 insertions(+), 27 deletions(-) > > diff --git u-boot-4d3c95f.orig/nand_spl/nand_boot_fsl_nfc.c u-boot-4d3c95f/nand_spl/nand_boot_fsl_nfc.c > index b90f93e..b98fe41 100644 > --- u-boot-4d3c95f.orig/nand_spl/nand_boot_fsl_nfc.c > +++ u-boot-4d3c95f/nand_spl/nand_boot_fsl_nfc.c > @@ -83,37 +83,35 @@ static void nfc_nand_command(unsigned short command) > nfc_wait_ready(); > } Surely a good issue to fix if we go on using nand_spl - however, as I said in my previous e-mail, nand_spl is obsolete and we move to the SPL framework. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================