* [U-Boot] arm: omap: Fix switching back to nandecc sw.
@ 2012-08-10 20:06 Jeroen Hofstee
2012-08-12 8:12 ` Igor Grinberg
2012-08-14 20:36 ` [U-Boot] [PATCH v2] " Jeroen Hofstee
0 siblings, 2 replies; 6+ messages in thread
From: Jeroen Hofstee @ 2012-08-10 20:06 UTC (permalink / raw)
To: u-boot
Switching back to nandecc sw fails to write correctly. A fix for this is
already mentioned in the thread below, lets fix it.
mentioned in http://lists.denx.de/pipermail/u-boot/2012-February/119002.html
Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
---
drivers/mtd/nand/omap_gpmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
index ca868ef..71aec1a 100644
--- a/drivers/mtd/nand/omap_gpmc.c
+++ b/drivers/mtd/nand/omap_gpmc.c
@@ -280,6 +280,7 @@ void omap_nand_switch_ecc(int32_t hardware)
omap_hwecc_init(nand);
printf("HW ECC selected\n");
} else {
+ nand->ecc.size = 0;
nand->ecc.mode = NAND_ECC_SOFT;
/* Use mtd default settings */
nand->ecc.layout = NULL;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] arm: omap: Fix switching back to nandecc sw.
2012-08-10 20:06 [U-Boot] arm: omap: Fix switching back to nandecc sw Jeroen Hofstee
@ 2012-08-12 8:12 ` Igor Grinberg
2012-08-12 12:11 ` Nikita Kiryanov
2012-08-14 20:36 ` [U-Boot] [PATCH v2] " Jeroen Hofstee
1 sibling, 1 reply; 6+ messages in thread
From: Igor Grinberg @ 2012-08-12 8:12 UTC (permalink / raw)
To: u-boot
Hi Jeroen,
Thanks for the patch!
On 08/10/12 23:06, Jeroen Hofstee wrote:
> Switching back to nandecc sw fails to write correctly. A fix for this is
> already mentioned in the thread below, lets fix it.
>
> mentioned in http://lists.denx.de/pipermail/u-boot/2012-February/119002.html
I would expect to have an actual explanation in the commit message
instead of (or along with) the link above and not just something like:
we fix nandecc sw, want to know more, go somewhere else...
>
> Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
After the commit message is fixed,
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> drivers/mtd/nand/omap_gpmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
> index ca868ef..71aec1a 100644
> --- a/drivers/mtd/nand/omap_gpmc.c
> +++ b/drivers/mtd/nand/omap_gpmc.c
> @@ -280,6 +280,7 @@ void omap_nand_switch_ecc(int32_t hardware)
> omap_hwecc_init(nand);
> printf("HW ECC selected\n");
> } else {
> + nand->ecc.size = 0;
> nand->ecc.mode = NAND_ECC_SOFT;
> /* Use mtd default settings */
> nand->ecc.layout = NULL;
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] arm: omap: Fix switching back to nandecc sw.
2012-08-12 8:12 ` Igor Grinberg
@ 2012-08-12 12:11 ` Nikita Kiryanov
0 siblings, 0 replies; 6+ messages in thread
From: Nikita Kiryanov @ 2012-08-12 12:11 UTC (permalink / raw)
To: u-boot
Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
On Sun, Aug 12, 2012 at 11:12 AM, Igor Grinberg <grinberg@compulab.co.il>wrote:
> Hi Jeroen,
>
> Thanks for the patch!
>
> On 08/10/12 23:06, Jeroen Hofstee wrote:
> > Switching back to nandecc sw fails to write correctly. A fix for this is
> > already mentioned in the thread below, lets fix it.
> >
> > mentioned in
> http://lists.denx.de/pipermail/u-boot/2012-February/119002.html
>
> I would expect to have an actual explanation in the commit message
> instead of (or along with) the link above and not just something like:
> we fix nandecc sw, want to know more, go somewhere else...
>
> >
> > Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
>
> After the commit message is fixed,
>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>
> > ---
> > drivers/mtd/nand/omap_gpmc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
> > index ca868ef..71aec1a 100644
> > --- a/drivers/mtd/nand/omap_gpmc.c
> > +++ b/drivers/mtd/nand/omap_gpmc.c
> > @@ -280,6 +280,7 @@ void omap_nand_switch_ecc(int32_t hardware)
> > omap_hwecc_init(nand);
> > printf("HW ECC selected\n");
> > } else {
> > + nand->ecc.size = 0;
> > nand->ecc.mode = NAND_ECC_SOFT;
> > /* Use mtd default settings */
> > nand->ecc.layout = NULL;
>
> --
> Regards,
> Igor.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] arm: omap: Fix switching back to nandecc sw.
2012-08-10 20:06 [U-Boot] arm: omap: Fix switching back to nandecc sw Jeroen Hofstee
2012-08-12 8:12 ` Igor Grinberg
@ 2012-08-14 20:36 ` Jeroen Hofstee
2012-08-14 20:39 ` Jeroen Hofstee
2012-08-24 23:39 ` Tom Rini
1 sibling, 2 replies; 6+ messages in thread
From: Jeroen Hofstee @ 2012-08-14 20:36 UTC (permalink / raw)
To: u-boot
version 2:
Updated the commit message to include the explanation from the
original thread.
For cosmetic reasons, move the added line 2 lines down, so it
is similiar to the hw case.
Add original author and maintainer on cc.
Jeroen Hofstee (1):
arm: omap2+: Fix switching back to nandecc sw.
drivers/mtd/nand/omap_gpmc.c | 1 +
1 file changed, 1 insertion(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH v2] arm: omap: Fix switching back to nandecc sw.
2012-08-14 20:36 ` [U-Boot] [PATCH v2] " Jeroen Hofstee
@ 2012-08-14 20:39 ` Jeroen Hofstee
2012-08-24 23:39 ` Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Jeroen Hofstee @ 2012-08-14 20:39 UTC (permalink / raw)
To: u-boot
Orjan Friberg wrote at [1]:
"For the beagleboard, ecc.size is not explicitly set when doing 'nandecc
sw'. If it's not set for the NAND_ECC_SOFT case in nand_scan_tail, it's
set to 256 bytes.
When doing 'nandecc hw', ecc.size is set to 512 bytes. Hence, when
changing back to 'nandecc sw' ecc.size remains at 512 bytes and suddenly
the format has changed."
No patch has been submitted and the issue was still present. This patch
adds the mentioned solution. Tested on a tam3517 board.
[1] http://lists.denx.de/pipermail/u-boot/2012-February/119002.html
cc: Orjan Friberg <of@flatfrog.com>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
---
drivers/mtd/nand/omap_gpmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
index ca868ef..f1469d1 100644
--- a/drivers/mtd/nand/omap_gpmc.c
+++ b/drivers/mtd/nand/omap_gpmc.c
@@ -283,6 +283,7 @@ void omap_nand_switch_ecc(int32_t hardware)
nand->ecc.mode = NAND_ECC_SOFT;
/* Use mtd default settings */
nand->ecc.layout = NULL;
+ nand->ecc.size = 0;
printf("SW ECC selected\n");
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH v2] arm: omap: Fix switching back to nandecc sw.
2012-08-14 20:36 ` [U-Boot] [PATCH v2] " Jeroen Hofstee
2012-08-14 20:39 ` Jeroen Hofstee
@ 2012-08-24 23:39 ` Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2012-08-24 23:39 UTC (permalink / raw)
To: u-boot
On Tue, Aug 14, 2012 at 10:36:19PM +0200, Jeroen Hofstee wrote:
> version 2:
> Updated the commit message to include the explanation from the
> original thread.
>
> For cosmetic reasons, move the added line 2 lines down, so it
> is similiar to the hw case.
>
> Add original author and maintainer on cc.
>
> Jeroen Hofstee (1):
> arm: omap2+: Fix switching back to nandecc sw.
Queued up for u-boot-ti/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120824/62345557/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-24 23:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-10 20:06 [U-Boot] arm: omap: Fix switching back to nandecc sw Jeroen Hofstee
2012-08-12 8:12 ` Igor Grinberg
2012-08-12 12:11 ` Nikita Kiryanov
2012-08-14 20:36 ` [U-Boot] [PATCH v2] " Jeroen Hofstee
2012-08-14 20:39 ` Jeroen Hofstee
2012-08-24 23:39 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox