public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kw_spi: fix clock prescaler computation
Date: Wed, 15 Aug 2012 17:26:14 +0200	[thread overview]
Message-ID: <502BBF96.7070306@keymile.com> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D1A58613FA7@SC-VEXCH4.marvell.com>

Hi Prafulla,

On 08/14/2012 03:15 PM, Prafulla Wadaskar wrote:
> 
> 
>> -----Original Message-----
>> From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
>> Sent: 14 August 2012 15:02
>> To: Prafulla Wadaskar
>> Cc: u-boot at lists.denx.de; Holger Brunck
>> Subject: Re: [PATCH] kw_spi: fix clock prescaler computation
>>
>> Hi Prafulla,
>>
>> I haven't received feedback about this patch from you. Can I please
>> kindly
>> remind you about it since I am about to send patches that deal with
>> SPI clk setting.
> 
> Dear Valentin
> My bad :-( I am really sorry about this.
> I missed this patch.
> Please find my comments in lined.
> 
>>
>> Thank you.
>>
>> On 06/29/2012 02:17 PM, Valentin Longchamp wrote:
>>> The computation was not correct with low clock values: setting a
>> 1MHz
>>> clock would result in an overlap that would then configure a 25Mhz
>>> clock.
>>>
>>> This patch implements a correct computation method according to the
>>> kirkwood functionnal spec. table 629 (Serial Memory Interface
>>> Configuration Register).
> 
> I think this is table 600 (ref: MV-S104860-00 Rev. E specs available on extranet)
> This is a cosmetic change.
> 
> Otherwise I ack for this patch.
> 
> Please kindly let me know, should I pull this patch or you will resend it with above change?

Ok, I had taken rev. C of the document as a reference, I will resend the patch
with the updated commit message.

Valentin

  reply	other threads:[~2012-08-15 15:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 12:17 [U-Boot] [PATCH] kw_spi: fix clock prescaler computation Valentin Longchamp
2012-08-14  9:32 ` Valentin Longchamp
2012-08-14 13:15   ` Prafulla Wadaskar
2012-08-15 15:26     ` Valentin Longchamp [this message]
2012-08-15 15:31       ` [U-Boot] [PATCH v2] " Valentin Longchamp
2012-08-16  4:13         ` Prafulla Wadaskar
2012-09-03  8:43         ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502BBF96.7070306@keymile.com \
    --to=valentin.longchamp@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox