From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valentin Longchamp Date: Wed, 15 Aug 2012 17:26:14 +0200 Subject: [U-Boot] [PATCH] kw_spi: fix clock prescaler computation In-Reply-To: References: <1340972242-24360-1-git-send-email-valentin.longchamp@keymile.com><502A1B1B.5020802@keymile.com> Message-ID: <502BBF96.7070306@keymile.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Prafulla, On 08/14/2012 03:15 PM, Prafulla Wadaskar wrote: > > >> -----Original Message----- >> From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com] >> Sent: 14 August 2012 15:02 >> To: Prafulla Wadaskar >> Cc: u-boot at lists.denx.de; Holger Brunck >> Subject: Re: [PATCH] kw_spi: fix clock prescaler computation >> >> Hi Prafulla, >> >> I haven't received feedback about this patch from you. Can I please >> kindly >> remind you about it since I am about to send patches that deal with >> SPI clk setting. > > Dear Valentin > My bad :-( I am really sorry about this. > I missed this patch. > Please find my comments in lined. > >> >> Thank you. >> >> On 06/29/2012 02:17 PM, Valentin Longchamp wrote: >>> The computation was not correct with low clock values: setting a >> 1MHz >>> clock would result in an overlap that would then configure a 25Mhz >>> clock. >>> >>> This patch implements a correct computation method according to the >>> kirkwood functionnal spec. table 629 (Serial Memory Interface >>> Configuration Register). > > I think this is table 600 (ref: MV-S104860-00 Rev. E specs available on extranet) > This is a cosmetic change. > > Otherwise I ack for this patch. > > Please kindly let me know, should I pull this patch or you will resend it with above change? Ok, I had taken rev. C of the document as a reference, I will resend the patch with the updated commit message. Valentin