From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 15 Aug 2012 12:13:31 -0500 Subject: [U-Boot] [PATCHv2 1/2] mpc85xx: Initial SP alignment is wrong. In-Reply-To: References: <1343077083-13983-1-git-send-email-Joakim.Tjernlund@transmode.se> <9B397335-5AAA-4594-931F-7AFE8011F6FB@kernel.crashing.org> Message-ID: <502BD8BB.3090709@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/15/2012 02:10 AM, Joakim Tjernlund wrote: > Kumar Gala wrote on 2012/08/14 23:28:45: >> >> >> On Jul 23, 2012, at 3:58 PM, Joakim Tjernlund wrote: >> >>> PowerPC mandates SP to be 16 bytes aligned. >>> Furthermore, a stack frame is added, pointing to the reset vector >>> which may in the way when gdb is walking the stack because >>> the reset vector may not accessible depending on emulator settings. >>> Also use a temp register so gdb doesn't pick up intermediate values. >>> >>> Signed-off-by: Joakim Tjernlund >>> --- >>> >>> v2 - Address Scott Wood's comments >>> arch/powerpc/cpu/mpc85xx/start.S | 16 +++++----------- >>> 1 files changed, 5 insertions(+), 11 deletions(-) >> >> Acked-by: Kumar Gala > > Thanks Kumar > > Will you pick up? > [PATCHv2 2/2] powerpc: Stack Pointer not properly aligned > > It is not 85xx specific but for all PowerPC I don't think Kumar has a U-Boot tree to pull it into. There's no general PPC custodian. Probably both patches should go via Andy. -Scott