public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm/km: add mv88e6352 configuration for kmnusa
Date: Fri, 17 Aug 2012 10:43:05 +0200	[thread overview]
Message-ID: <502E0419.6040803@keymile.com> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D1A586C1C40@SC-VEXCH4.marvell.com>

On 08/17/2012 09:59 AM, Prafulla Wadaskar wrote:
> 
> 
>> -----Original Message-----
>> From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
>> Sent: 16 August 2012 16:55
>> To: u-boot at lists.denx.de
>> Cc: holger.brunck at keymile.com; Prafulla Wadaskar;
>> valentin.longchamp at keymile.com
>> Subject: [PATCH 1/2] arm/km: add mv88e6352 configuration for kmnusa
>>
>> The kmnusa board uses a mv88e6352 switch that is connected to the main
>> eth interface of the kirkwood. Therefore the switch must be configured
>> so that the kirkwood's egiga eth inferface can be used.
>>
>> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
>> Cc: Holger Brunck <holger.brunck@keymile.com>
>> Cc: Prafulla Wadaskar <prafulla@marvell.com>
>> ---
>>  board/keymile/km_arm/km_arm.c |   63
>> +++++++++++++++++++++++++++++++++++++++++
>>  1 files changed, 63 insertions(+), 0 deletions(-)
>>
>> diff --git a/board/keymile/km_arm/km_arm.c
>> b/board/keymile/km_arm/km_arm.c
>> index 2b2ca39..c0069c1 100644
>> --- a/board/keymile/km_arm/km_arm.c
>> +++ b/board/keymile/km_arm/km_arm.c
>> @@ -385,6 +385,69 @@ void reset_phy(void)
>>  	/* reset the phy */
>>  	miiphy_reset(name, CONFIG_PHY_BASE_ADR);
>>  }
>> +#elif defined(CONFIG_KM_PIGGY4_88E6352)
>> +
>> +#include <mv88e6352.h>
>> +
>> +#if defined(CONFIG_KM_NUSA)
>> +struct mv88e_sw_reg extsw_conf[] = {
>> +	/* port 0, PIGY4, autoneg */
>> +	/* first the fix for the 1000Mbits Autoneg, this is from
>> +	 * a Marvell errata, the regs are undocumented */
> 
> May you please follow standard c-style commenting?
> 

OK, I will change this comment. Is it OK if I just repost this updated patch as
a reply to this message since it's a very minor change or do you need the whole
series ?

Thanks

Valentin

  reply	other threads:[~2012-08-17  8:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16 11:25 [U-Boot] [PATCH 0/2] arm/km: configuration of the mv88e6352 switch on kmnusa Valentin Longchamp
2012-08-16 11:25 ` [U-Boot] [PATCH 1/2] arm/km: add mv88e6352 configuration for kmnusa Valentin Longchamp
2012-08-17  7:59   ` Prafulla Wadaskar
2012-08-17  8:43     ` Valentin Longchamp [this message]
2012-08-17  8:53       ` Prafulla Wadaskar
2012-08-17  9:35         ` [U-Boot] [PATCH v2 " Valentin Longchamp
2012-08-21  6:31           ` Prafulla Wadaskar
2012-09-28  6:43           ` Prafulla Wadaskar
2012-08-16 11:25 ` [U-Boot] [PATCH 2/2] km_kirkwood: enable MV88E6352_SWITCH support " Valentin Longchamp
2012-08-17  7:59   ` Prafulla Wadaskar
2012-09-28  6:43   ` Prafulla Wadaskar
2012-08-17  7:59 ` [U-Boot] [PATCH 0/2] arm/km: configuration of the mv88e6352 switch on kmnusa Prafulla Wadaskar
2012-09-03  8:11 ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502E0419.6040803@keymile.com \
    --to=valentin.longchamp@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox