* [U-Boot] [PATCH] mx5/6 timer: Round up tick_to_time() value
@ 2012-08-14 15:01 Benoît Thébaudeau
2012-08-17 19:55 ` Stefano Babic
2012-08-20 7:56 ` Stefano Babic
0 siblings, 2 replies; 3+ messages in thread
From: Benoît Thébaudeau @ 2012-08-14 15:01 UTC (permalink / raw)
To: u-boot
Round up tick_to_time() value instead of truncating it. This avoids stopping
waits instantly for low usec values, and this generally guarantees that the code
always waits for at least the requested duration.
Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
Cc: Stefano Babic <sbabic@denx.de>
---
.../arch/arm/cpu/armv7/imx-common/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git u-boot-4d3c95f.orig/arch/arm/cpu/armv7/imx-common/timer.c u-boot-4d3c95f/arch/arm/cpu/armv7/imx-common/timer.c
index 1645ff8..e2725e1 100644
--- u-boot-4d3c95f.orig/arch/arm/cpu/armv7/imx-common/timer.c
+++ u-boot-4d3c95f/arch/arm/cpu/armv7/imx-common/timer.c
@@ -61,7 +61,7 @@ static inline unsigned long long tick_to_time(unsigned long long tick)
static inline unsigned long long us_to_tick(unsigned long long usec)
{
- usec *= CLK_32KHZ;
+ usec = usec * CLK_32KHZ + 999999;
do_div(usec, 1000000);
return usec;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mx5/6 timer: Round up tick_to_time() value
2012-08-14 15:01 [U-Boot] [PATCH] mx5/6 timer: Round up tick_to_time() value Benoît Thébaudeau
@ 2012-08-17 19:55 ` Stefano Babic
2012-08-20 7:56 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2012-08-17 19:55 UTC (permalink / raw)
To: u-boot
On 14/08/2012 17:01, Beno?t Th?baudeau wrote:
> Round up tick_to_time() value instead of truncating it. This avoids stopping
> waits instantly for low usec values, and this generally guarantees that the code
> always waits for at least the requested duration.
>
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> .../arch/arm/cpu/armv7/imx-common/timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git u-boot-4d3c95f.orig/arch/arm/cpu/armv7/imx-common/timer.c u-boot-4d3c95f/arch/arm/cpu/armv7/imx-common/timer.c
> index 1645ff8..e2725e1 100644
> --- u-boot-4d3c95f.orig/arch/arm/cpu/armv7/imx-common/timer.c
> +++ u-boot-4d3c95f/arch/arm/cpu/armv7/imx-common/timer.c
> @@ -61,7 +61,7 @@ static inline unsigned long long tick_to_time(unsigned long long tick)
>
> static inline unsigned long long us_to_tick(unsigned long long usec)
> {
> - usec *= CLK_32KHZ;
> + usec = usec * CLK_32KHZ + 999999;
> do_div(usec, 1000000);
>
> return usec;
>
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mx5/6 timer: Round up tick_to_time() value
2012-08-14 15:01 [U-Boot] [PATCH] mx5/6 timer: Round up tick_to_time() value Benoît Thébaudeau
2012-08-17 19:55 ` Stefano Babic
@ 2012-08-20 7:56 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2012-08-20 7:56 UTC (permalink / raw)
To: u-boot
On 14/08/2012 17:01, Beno?t Th?baudeau wrote:
> Round up tick_to_time() value instead of truncating it. This avoids stopping
> waits instantly for low usec values, and this generally guarantees that the code
> always waits for at least the requested duration.
>
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> .../arch/arm/cpu/armv7/imx-common/timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git u-boot-4d3c95f.orig/arch/arm/cpu/armv7/imx-common/timer.c u-boot-4d3c95f/arch/arm/cpu/armv7/imx-common/timer.c
> index 1645ff8..e2725e1 100644
> --- u-boot-4d3c95f.orig/arch/arm/cpu/armv7/imx-common/timer.c
> +++ u-boot-4d3c95f/arch/arm/cpu/armv7/imx-common/timer.c
> @@ -61,7 +61,7 @@ static inline unsigned long long tick_to_time(unsigned long long tick)
>
> static inline unsigned long long us_to_tick(unsigned long long usec)
> {
> - usec *= CLK_32KHZ;
> + usec = usec * CLK_32KHZ + 999999;
> do_div(usec, 1000000);
>
> return usec;
>
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-20 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-14 15:01 [U-Boot] [PATCH] mx5/6 timer: Round up tick_to_time() value Benoît Thébaudeau
2012-08-17 19:55 ` Stefano Babic
2012-08-20 7:56 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox