From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefano babic Date: Sat, 18 Aug 2012 11:05:58 +0200 Subject: [U-Boot] [PATCH 1/2] spi: fix mxc_spi_slave structure allocation to clear memory In-Reply-To: <1345227311-11433-1-git-send-email-matt@genesi-usa.com> References: <1345227311-11433-1-git-send-email-matt@genesi-usa.com> Message-ID: <502F5AF6.8010404@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 17/08/2012 20:15, schrieb Matt Sealey: > Use calloc() instead of malloc() to allocate the mxc_spi_slave structure. > Clearing the memory is necessary since most of the time this gets done > super early in boot, but on warm reboots, and when SPI probing is done > long after the init stages it could actually pick up previously used memory, > and things like the chipselect polarity and other data end up being filled > with trash data if not explicitly set by the board files. > > This solves a semi-random, almost unreproducable error whereby SPI devices > act very, very strangly on boot. Tested on Efika MX over several years.. > > Signed-off-by: Matt Sealey > --- > drivers/spi/mxc_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c > index 2e15318..d1dab18 100644 > --- a/drivers/spi/mxc_spi.c > +++ b/drivers/spi/mxc_spi.c > @@ -408,7 +408,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs, > if (bus >= ARRAY_SIZE(spi_bases)) > return NULL; > > - mxcs = malloc(sizeof(struct mxc_spi_slave)); > + mxcs = calloc(sizeof(struct mxc_spi_slave), 1); > if (!mxcs) { > puts("mxc_spi: SPI Slave not allocated !\n"); > return NULL; > Agree, the structure must be zeroed. Acked-by: Stefano Babic Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================