From: Jeroen Hofstee <dasuboot@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/lcd: add protection from null bmp pointer
Date: Sat, 18 Aug 2012 13:09:57 +0200 [thread overview]
Message-ID: <502F7805.80301@myspectrum.nl> (raw)
In-Reply-To: <502E89D1.1070205@myspectrum.nl>
Hi,
> On 08/16/2012 12:43 PM, Nikita Kiryanov wrote:
>> If the bmp pointer is null (for example because the environment
>> variable "splashimage" was not defined) then U-Boot will get stuck
>> when trying to load the image.
> Which branch is this? At [1] there is a check for this..
>
> 1600 s = getenv("splashimage");
> 1601 if (s != NULL) {
> ...
>
> Regards,
> Jeroen
>
> [1] .... drivers/video/cfb_console.c.....
Just ignore above, since there are apparently more BMP drawing routines,
and I mentioned the wrong one. The same check is in lcd.c though:
822: if (do_splash && (s = getenv("splashimage")) != NULL) {
Regards,
Jeroen
next prev parent reply other threads:[~2012-08-18 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 10:43 [U-Boot] [PATCH] common/lcd: add protection from null bmp pointer Nikita Kiryanov
2012-08-17 18:13 ` Jeroen Hofstee
2012-08-18 11:09 ` Jeroen Hofstee [this message]
2012-08-20 6:12 ` Nikita Kiryanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502F7805.80301@myspectrum.nl \
--to=dasuboot@myspectrum.nl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox