From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeroen Hofstee <dasuboot@myspectrum.nl>
Date: Sat, 18 Aug 2012 13:09:57 +0200
Subject: [U-Boot] [PATCH] common/lcd: add protection from null bmp
	pointer
In-Reply-To: <502E89D1.1070205@myspectrum.nl>
References: <1345113809-7871-1-git-send-email-nikita@compulab.co.il>
	<502E89D1.1070205@myspectrum.nl>
Message-ID: <502F7805.80301@myspectrum.nl>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,
> On 08/16/2012 12:43 PM, Nikita Kiryanov wrote:
>> If the bmp pointer is null (for example because the environment
>> variable "splashimage" was not defined) then U-Boot will get stuck
>> when trying to load the image.
> Which branch is this? At [1] there is a check for this..
>
> 1600         s = getenv("splashimage");
> 1601         if (s != NULL) {
> ...
>
> Regards,
> Jeroen
>
> [1] .... drivers/video/cfb_console.c.....
Just ignore above, since there are apparently more BMP drawing routines,
and I mentioned the wrong one. The same check is in lcd.c though:

822: if (do_splash && (s = getenv("splashimage")) != NULL) {

Regards,
Jeroen