[U-Boot] [PATCH] mx5: add iomux-mx51.h include

[stefano babic <sbabic@denx.de>]

Am 18/08/2012 23:18, schrieb Matt Sealey:

> 
> I will, for now it's the top of Linus' tree, but this code is going to
> get removed from the Linux kernel soon, so I understand, we need to
> figure out where it will last forever (probably linux-stable at 3.5) so
> we can always reference it.

Right. Add the Linux commit-id in your commit message.

> 
>> I do like we add a second identical defeine why we discover an issue in
>> another part of code. I know for experience that code introduced this
>> the goal to fix it later will never be fixed. So let's see if we can jut
>> do the right thing.
>>
>> I do not think imx-common/iomux-v3.h is the right place. What has the
>> pinmux with gpio to do? This is also wrong....it is GPIO related, it
>> should go into gpio.h.
> 
> That's true. I did not want to mess the patchset up with boards I
> cannot test though, and I don't like committing code I didn't test
> (mx3 gpio etc.) even if the docs say as much as it's identical. I see
> you already fixed that though.

Ok, but again thanks for raise the issue.

> 
> I'll rebase on Monday and submit something new... see below, though..
> 
>>> +
>>> +#endif /* __IOMUX_MX51_H__ */
>>>
>>
>> Ok, good, this is the same as in kernel.
> 
> Right. This all came from a discussion with Troy and Eric at
> BoundaryDevices about i2c multi-bus support, they sent us a file with
> MX6 support and a hack for MX5 support to go with it; it didn't work
> and I figured it'd be a good thing to complete. Troy suggested not
> copying the Linux file verbatim (after all, why include camera bus
> pinmux when U-Boot won't support a camera bus?) and just include the
> pins we wanted.

I agree with Troy. U-boot should set only what it needs, nothing more.

> 
> I just noticed that the imx-common/iomux-v3.h is out of date re the
> latest kernel too (some bits have moved as MX6 needs extra space to
> store some setting) so I'll patch that in as well.
> 
> I think we need to make a small discussion point here (new thread?)
> about what needs to be done and what has been done, since if this
> isn't a tree and just patches on a mailing list or in a patchwork it's
> infuriatingly hard to track what is going on and who patched what and
> what to base against.

Youm see that the maintainer's work can be hard...;-)

> I may have to wait until something like your
> gpio.h changes hit the u-boot-imx tree..

I got a lot of patches in the last time, not only from you and Benoit.
Some of them are related, and I do not want to push a broken tree. My
plan is to merge the patches that are acked and free of comments,
pushing them to u-boot-imx. I think you have not to wait long.

Best regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================