public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: stefano babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] efikamx: remove drive strength hack from early_init_f and move it to the DCD
Date: Sun, 19 Aug 2012 00:56:31 +0200	[thread overview]
Message-ID: <50301D9F.6040906@denx.de> (raw)
In-Reply-To: <201208190029.17209.marex@denx.de>

Am 19/08/2012 00:29, schrieb Marek Vasut:
> Dear Matt Sealey,
> 
>> On Sat, Aug 18, 2012 at 10:34 AM, Stefano Babic <sbabic@denx.de> wrote:
>>> On 17/08/2012 20:19, Matt Sealey wrote:
>>>> The i.MX Boot ROM lets us set up certain registers before U-Boot even
>>>> gets executed. Rather than setting up DDR, putting U-Boot in place, and
>>>> getting into pre-relocation init to set up DDR again, just do it once
>>>> in the correct place. This also solves an issue where the Smarttop DDR
>>>> pad settings were being applied on Smartbook.
>>>>
>>>> While we're at it, configure PCBID0,1,2 and the LED GPIO since we've
>>>> still got room in the DCD to do so.
>>>>
>>>> Signed-off-by: Matt Sealey <matt@genesi-usa.com>
>>>> ---
>>>
>>> Hi Matt,
>>>
>>>> diff --git a/board/genesi/mx51_efikamx/imximage_mx.cfg
>>>> b/board/genesi/mx51_efikamx/imximage_mx.cfg index 6fe0ff9..ac9aa9a
>>>> 100644
>>>> --- a/board/genesi/mx51_efikamx/imximage_mx.cfg
>>>> +++ b/board/genesi/mx51_efikamx/imximage_mx.cfg
>>>> @@ -1,7 +1,7 @@
>>>>
>>>>  #
>>>>
>>>> +# Copyright (C) 2009 Pegatron Corporation
>>>>
>>>                     ^---
>>>
>>> Was this added for mistake ? I think you should add only yours.
>>
>> The drive strength settings came from Pegatron a long, long time ago
>> (2009 :) and our old config and the function is copyrighted to them.
>> Just because Marek took them out and recopyrighted the file I derived
>> them from in this case doesn't mean they lost their copyright..
> 
> This file was taken from mx51evk. It's written there. Please stop this nonsense, 
> it's troubling me.

Then Pegatron has nothing to do with it. The original comes from
Freescale, and the copyright was set.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2012-08-18 22:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17 18:19 [U-Boot] [PATCH 0/4] efikamx: update Efika MX support Matt Sealey
2012-08-17 18:19 ` [U-Boot] [PATCH 1/4] efikamx: move efikamx into a new directory in preparation for new boards Matt Sealey
2012-08-17 21:01   ` Marek Vasut
2012-08-17 22:21     ` Matt Sealey
2012-08-17 18:19 ` [U-Boot] [PATCH 2/4] efikamx: remove drive strength hack from early_init_f and move it to the DCD Matt Sealey
2012-08-17 21:03   ` Marek Vasut
2012-08-17 22:05     ` Matt Sealey
2012-08-17 23:39       ` Marek Vasut
2012-08-18 15:34   ` Stefano Babic
2012-08-18 21:11     ` Matt Sealey
2012-08-18 22:29       ` Marek Vasut
2012-08-18 22:56         ` stefano babic [this message]
2012-08-20 16:34           ` Matt Sealey
2012-08-18 22:39       ` stefano babic
2012-08-17 18:19 ` [U-Boot] [PATCH 3/4] efikamx: update to Efika MX Smarttop and Smartbook boards Matt Sealey
2012-08-17 19:29   ` Benoît Thébaudeau
2012-08-17 20:10     ` Matt Sealey
2012-08-17 21:07   ` Marek Vasut
2012-08-17 22:17     ` Matt Sealey
2012-08-17 23:38       ` Marek Vasut
2012-08-18 15:50   ` Stefano Babic
2012-08-18 21:02     ` Matt Sealey
2012-08-18 22:26       ` Marek Vasut
2012-08-20 16:19         ` Matt Sealey
2012-08-21  2:21           ` Marek Vasut
2012-08-18 22:31       ` stefano babic
2012-08-17 18:19 ` [U-Boot] [PATCH 4/4] efikamx: port USB setup to new iomux model Matt Sealey
2012-08-17 20:59 ` [U-Boot] [PATCH 0/4] efikamx: update Efika MX support Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50301D9F.6040906@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox