From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefano babic Date: Sun, 19 Aug 2012 00:56:31 +0200 Subject: [U-Boot] [PATCH 2/4] efikamx: remove drive strength hack from early_init_f and move it to the DCD In-Reply-To: <201208190029.17209.marex@denx.de> References: <1345227562-11502-1-git-send-email-matt@genesi-usa.com> <502FB5F2.5090108@denx.de> <201208190029.17209.marex@denx.de> Message-ID: <50301D9F.6040906@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 19/08/2012 00:29, schrieb Marek Vasut: > Dear Matt Sealey, > >> On Sat, Aug 18, 2012 at 10:34 AM, Stefano Babic wrote: >>> On 17/08/2012 20:19, Matt Sealey wrote: >>>> The i.MX Boot ROM lets us set up certain registers before U-Boot even >>>> gets executed. Rather than setting up DDR, putting U-Boot in place, and >>>> getting into pre-relocation init to set up DDR again, just do it once >>>> in the correct place. This also solves an issue where the Smarttop DDR >>>> pad settings were being applied on Smartbook. >>>> >>>> While we're at it, configure PCBID0,1,2 and the LED GPIO since we've >>>> still got room in the DCD to do so. >>>> >>>> Signed-off-by: Matt Sealey >>>> --- >>> >>> Hi Matt, >>> >>>> diff --git a/board/genesi/mx51_efikamx/imximage_mx.cfg >>>> b/board/genesi/mx51_efikamx/imximage_mx.cfg index 6fe0ff9..ac9aa9a >>>> 100644 >>>> --- a/board/genesi/mx51_efikamx/imximage_mx.cfg >>>> +++ b/board/genesi/mx51_efikamx/imximage_mx.cfg >>>> @@ -1,7 +1,7 @@ >>>> >>>> # >>>> >>>> +# Copyright (C) 2009 Pegatron Corporation >>>> >>> ^--- >>> >>> Was this added for mistake ? I think you should add only yours. >> >> The drive strength settings came from Pegatron a long, long time ago >> (2009 :) and our old config and the function is copyrighted to them. >> Just because Marek took them out and recopyrighted the file I derived >> them from in this case doesn't mean they lost their copyright.. > > This file was taken from mx51evk. It's written there. Please stop this nonsense, > it's troubling me. Then Pegatron has nothing to do with it. The original comes from Freescale, and the copyright was set. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================