public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mx5/6: Fix cpu_mmc_init() return value
Date: Mon, 20 Aug 2012 10:00:51 +0200	[thread overview]
Message-ID: <5031EEB3.2010709@denx.de> (raw)
In-Reply-To: <1070429626.2524198.1345236175687.JavaMail.root@advansee.com>

On 17/08/2012 22:42, Beno?t Th?baudeau wrote:
> Do not pretend to have initialized mmc successfully if CONFIG_FSL_ESDHC is not
> defined. Instead, only implement a custom cpu_mmc_init() when it does something.
> 
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> Changes for v2:
>  - Do not define cpu_mmc_init() if CONFIG_FSL_ESDHC is not defined.
> 
>  .../arch/arm/cpu/armv7/imx-common/cpu.c            |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git u-boot-4d3c95f.orig/arch/arm/cpu/armv7/imx-common/cpu.c u-boot-4d3c95f/arch/arm/cpu/armv7/imx-common/cpu.c
> index b3195dd..7313fc0 100644
> --- u-boot-4d3c95f.orig/arch/arm/cpu/armv7/imx-common/cpu.c
> +++ u-boot-4d3c95f/arch/arm/cpu/armv7/imx-common/cpu.c
> @@ -111,18 +111,16 @@ int cpu_eth_init(bd_t *bis)
>  	return rc;
>  }
>  
> +#ifdef CONFIG_FSL_ESDHC
>  /*
>   * Initializes on-chip MMC controllers.
>   * to override, implement board_mmc_init()
>   */
>  int cpu_mmc_init(bd_t *bis)
>  {
> -#ifdef CONFIG_FSL_ESDHC
>  	return fsl_esdhc_mmc_init(bis);
> -#else
> -	return 0;
> -#endif
>  }
> +#endif
>  
>  void reset_cpu(ulong addr)
>  {
> 
Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      parent reply	other threads:[~2012-08-20  8:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 15:30 [U-Boot] [PATCH] mx5/6: Fix cpu_mmc_init() return value Benoît Thébaudeau
2012-08-17 11:49 ` Stefano Babic
2012-08-17 16:25   ` Benoît Thébaudeau
2012-08-17 20:42     ` [U-Boot] [PATCH v2] " Benoît Thébaudeau
2012-08-17 21:19       ` Stefano Babic
2012-08-20  8:00       ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5031EEB3.2010709@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox