From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] mx35: Fix broken pin definitions
Date: Mon, 20 Aug 2012 12:15:12 +0200 [thread overview]
Message-ID: <50320E30.5040902@denx.de> (raw)
In-Reply-To: <546994402.2410687.1344973189988.JavaMail.root@advansee.com>
On 14/08/2012 21:39, Beno?t Th?baudeau wrote:
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> .../arch/arm/include/asm/arch-mx35/mx35_pins.h | 3 ---
> .../board/CarMediaLab/flea3/flea3.c | 4 ++--
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git u-boot-4d3c95f.orig/arch/arm/include/asm/arch-mx35/mx35_pins.h u-boot-4d3c95f/arch/arm/include/asm/arch-mx35/mx35_pins.h
> index 8c38139..00e5e75 100644
> --- u-boot-4d3c95f.orig/arch/arm/include/asm/arch-mx35/mx35_pins.h
> +++ u-boot-4d3c95f/arch/arm/include/asm/arch-mx35/mx35_pins.h
> @@ -347,9 +347,6 @@ typedef enum iomux_pins {
> MX35_PIN_FEC_TDATA2 = _MXC_BUILD_GPIO_PIN(2, 21, 0x31C, 0x780),
> MX35_PIN_FEC_RDATA3 = _MXC_BUILD_GPIO_PIN(2, 22, 0x320, 0x784),
> MX35_PIN_FEC_TDATA3 = _MXC_BUILD_GPIO_PIN(2, 23, 0x324, 0x788),
> -
> - MX35_PIN_RTS2_UART3_RXD_MUX = _MXC_BUILD_NON_GPIO_PIN(0x1a0, 0x5e4),
> - MX35_PIN_CTS2_UART3_TXD_MUX = _MXC_BUILD_NON_GPIO_PIN(0x1a4, 0x5e8),
> } iomux_pin_name_t;
>
> #endif
> diff --git u-boot-4d3c95f.orig/board/CarMediaLab/flea3/flea3.c u-boot-4d3c95f/board/CarMediaLab/flea3/flea3.c
> index 34ede87..5015a1a 100644
> --- u-boot-4d3c95f.orig/board/CarMediaLab/flea3/flea3.c
> +++ u-boot-4d3c95f/board/CarMediaLab/flea3/flea3.c
> @@ -165,8 +165,8 @@ static void board_setup_sdram(void)
>
> static void setup_iomux_uart3(void)
> {
> - mxc_request_iomux(MX35_PIN_RTS2_UART3_RXD_MUX, MUX_CONFIG_ALT7);
> - mxc_request_iomux(MX35_PIN_CTS2_UART3_TXD_MUX, MUX_CONFIG_ALT7);
> + mxc_request_iomux(MX35_PIN_RTS2, MUX_CONFIG_ALT7);
> + mxc_request_iomux(MX35_PIN_CTS2, MUX_CONFIG_ALT7);
> }
>
That is correct, the pin was already defined.
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2012-08-20 10:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 19:39 [U-Boot] [PATCH 1/6] mx35 iomux: Remove unused macro Benoît Thébaudeau
2012-08-14 19:39 ` [U-Boot] [PATCH 2/6] mx35 gpio: Homogenize register naming Benoît Thébaudeau
2012-08-14 19:39 ` [U-Boot] [PATCH 3/6] mx35: Fix broken pin definitions Benoît Thébaudeau
2012-08-20 10:15 ` Stefano Babic [this message]
2012-08-23 9:08 ` Stefano Babic
2012-08-23 9:09 ` Stefano Babic
2012-08-14 19:40 ` [U-Boot] [PATCH 4/6] mx35: Remove declaration of non-existing function Benoît Thébaudeau
2012-08-20 10:18 ` Stefano Babic
2012-08-23 9:10 ` Stefano Babic
2012-08-14 19:40 ` [U-Boot] [PATCH 5/6] mx35: Add default pin initializers Benoît Thébaudeau
2012-08-20 10:20 ` Stefano Babic
2012-08-14 19:40 ` [U-Boot] [PATCH 6/6] mx35: Use " Benoît Thébaudeau
2012-08-20 10:17 ` [U-Boot] [PATCH 1/6] mx35 iomux: Remove unused macro Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50320E30.5040902@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox