From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 20 Aug 2012 12:25:26 -0600 Subject: [U-Boot] [PATCH 3/3] tegra20: add USB ULPI init code In-Reply-To: <1345392496-28739-4-git-send-email-dev@lynxeye.de> References: <1345392496-28739-1-git-send-email-dev@lynxeye.de> <1345392496-28739-4-git-send-email-dev@lynxeye.de> Message-ID: <50328116.90201@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/19/2012 10:08 AM, Lucas Stach wrote: > This adds the required code to set up a ULPI USB port. It is > mostly a port of the Linux ULPI setup code with some tweaks > added for more correctness, discovered along the way of > debugging this. > > To use this both CONFIG_USB_ULPI and CONFIG_USB_ULPI_VIEWPORT > have to be set in the board configuration file. > diff --git a/arch/arm/cpu/armv7/tegra20/usb.c b/arch/arm/cpu/armv7/tegra20/usb.c > -/* set up the USB controller with the parameters provided */ > -static int init_usb_controller(struct fdt_usb *config, > +/* set up the UTMI USB controller with the parameters provided */ > +static int init_utmi_usb_controller(struct fdt_usb *config, > struct usb_ctlr *usbctlr, const u32 timing[]) ... > +#ifdef CONFIG_USB_ULPI > +/* set up the ULPI USB controller with the parameters provided */ > +static int init_ulpi_usb_controller(struct fdt_usb *config, > + struct usb_ctlr *usbctlr) I'm not sure why there's a CONFIG_USB_ULPI and not a matching CONFIG_USB_UTMI; it seems rather unbalanced, but anyway... Aside from that, I don't have any other obvious objections to this.