public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/3] Tegra 2 USB ULPI series
Date: Wed, 22 Aug 2012 10:06:31 -0600	[thread overview]
Message-ID: <50350387.7050809@wwwdotorg.org> (raw)
In-Reply-To: <1345492773.6188.5.camel@selen>

On 08/20/2012 01:59 PM, Lucas Stach wrote:
> Am Montag, den 20.08.2012, 12:09 -0600 schrieb Stephen Warren:
>> On 08/19/2012 10:08 AM, Lucas Stach wrote:
>>> With this series we are able to initialize USB controllers
>>> using an external ULPI phy AKA USB2 on Tegra 2 devices.
>>>
>>> This was tested to work on a Toradex Colibri T20 board,
>>> where USB2 is used to access the ASIX ethernet chipset.
>>> Testing was done with "tegra20: usb: rework set_host_mode"
>>> applied. I did not spot any regressions on the UTMI ports.
>>>
>>> Patchset is based on top of u-boot-tegra/next
>>
>> Hmmm. I tried testing this on my local branch on Harmony, which has all
>> the patches necessary for multiple USB ports to work, and indeed they do
>> on Seaboard. However, this series (plus some Harmony-specific config and
>> .dts changes) didn't cause the ULPI port to work:-( Any idea why?
>>
> Could you try the attached hack and report back? If it doesn't help
> please build with DEBUG defined in
> arch/arm/cpu/armv7/tegra20/usb.c
> drivers/usb/host/ehci-hcd.c
> and provide me the output of the usb start command.

Oops. I had forgotten to enable ULPI/ULPI_VIEWPORT config options.

Now that I do that, U-Boot hangs when enabling the ULPI transceiver. I
see this with series v1, v1 plus the patch you included in the email I'm
replying to, and v2.

In particular, if I printf every line, the printf before the following
line appears, but not the one after it:

	setbits_le32(&usbctlr->susp_ctrl, ULPI_PHY_ENB);

If I comment that out, then the code runs farther, eventually hanging
inside ulpi_init(). Do you have any idea what's wrong?

      reply	other threads:[~2012-08-22 16:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-19 16:08 [U-Boot] [PATCH 0/3] Tegra 2 USB ULPI series Lucas Stach
2012-08-19 16:08 ` [U-Boot] [PATCH 1/3] tegra20: complete periph_id enum Lucas Stach
2012-08-20 18:12   ` Stephen Warren
2012-08-21 19:04   ` Simon Glass
2012-08-19 16:08 ` [U-Boot] [PATCH 2/3] tegra20: add clock_set_pllout function Lucas Stach
2012-08-20 18:19   ` Stephen Warren
2012-08-19 16:08 ` [U-Boot] [PATCH 3/3] tegra20: add USB ULPI init code Lucas Stach
2012-08-20 12:07   ` Igor Grinberg
2012-08-20 12:41     ` Lucas Stach
2012-08-20 18:27       ` Stephen Warren
2012-08-21  7:59         ` Igor Grinberg
2012-08-21  7:54       ` Igor Grinberg
2012-08-20 18:25   ` Stephen Warren
2012-08-20 12:27 ` [U-Boot] [PATCH 0/3] Tegra 2 USB ULPI series Igor Grinberg
2012-08-20 12:43   ` Lucas Stach
2012-08-20 18:09 ` Stephen Warren
2012-08-20 19:59   ` Lucas Stach
2012-08-22 16:06     ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50350387.7050809@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox