From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/1] mx31/mx35/mx51/mx53/mx6: add watchdog
Date: Wed, 22 Aug 2012 11:37:28 -0700 [thread overview]
Message-ID: <503526E8.9030803@boundarydevices.com> (raw)
In-Reply-To: <50352561.4020807@boundarydevices.com>
On 8/22/2012 11:30 AM, Troy Kisky wrote:
> On 8/22/2012 12:22 AM, Stefano Babic wrote:
>> On 21/08/2012 19:51, Troy Kisky wrote:
>>> On 8/20/2012 11:11 PM, Stefano Babic wrote:
>>>> On 21/08/2012 01:03, Troy Kisky wrote:
>>>>
>>> So, you are saying CONFIG_ options don't belong in imx-regs.h, or
>>> you didn't notice I stuck it there, or both???
>> I didn't notice, but CONFIG_ options do not belong to imx-regs.h. They
>> must be define only inside the board configuration file.
>>
>> Best regards,
>> Stefano
>>
> Would it be acceptable to put
> #if defined(CONFIG_MX31) || defined(CONFIG_MX35) ||
> defined(CONFIG_MX51) \
> || defined(CONFIG_MX53) || defined(CONFIG_MX6Q)
> #define CONFIG_IMX_WATCHDOG /* cpu_reset implemented in watchdog */
> #endif
>
>
> at the bottom of config_cmd_default.h or do you have a better place in
> mind?
>
> Thanks
> Troy
>
or perhaps
COBJS-$(CONFIG_MX31) += imx_watchdog.o
COBJS-$(CONFIG_MX35) += imx_watchdog.o
COBJS-$(CONFIG_MX51) += imx_watchdog.o
COBJS-$(CONFIG_MX53) += imx_watchdog.o
COBJS-$(CONFIG_MX6Q) += imx_watchdog.o
Thanks
Troy
next prev parent reply other threads:[~2012-08-22 18:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 23:03 [U-Boot] [PATCH V2 1/1] mx31/mx35/mx51/mx53/mx6: add watchdog Troy Kisky
2012-08-21 6:11 ` Stefano Babic
2012-08-21 17:51 ` Troy Kisky
2012-08-22 7:22 ` Stefano Babic
2012-08-22 18:30 ` Troy Kisky
2012-08-22 18:37 ` Troy Kisky [this message]
2012-08-23 9:19 ` Stefano Babic
2012-09-01 7:59 ` Stefano Babic
2012-10-23 1:19 ` [U-Boot] [PATCH V3 " Troy Kisky
2012-10-25 10:56 ` Stefano Babic
2012-10-28 11:48 ` Stefano Babic
2013-01-11 23:26 ` Troy Kisky
2013-01-13 10:43 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503526E8.9030803@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox