From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <stefan.roese@gmail.com>
Date: Thu, 23 Aug 2012 10:51:30 +0200
Subject: [U-Boot] [PATCH] SPL: do not use fix value for u-boot size
In-Reply-To: <1345711214-11969-1-git-send-email-sbabic@denx.de>
References: <1345711214-11969-1-git-send-email-sbabic@denx.de>
Message-ID: <5035EF12.4020505@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/23/2012 10:40 AM, Stefano Babic wrote:
> If an u-boot image is not found, SPL thinks to load a bare
> u-boot.bin image with a maximum size of 200KB.
> Use CONFIG_SYS_MONITOR_LEN instead.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> CC: Tom Rini <trini@ti.com>
> ---
> 
> Note: this is based on Tom's series
> 	"ARM: SPL: Make more generic, merge DaVinci and OMAP"
> 
> Tested with V2 version on a MX35.
> 
>  common/spl/spl.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index 7d15460..827ff1c 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -100,7 +100,11 @@ void spl_parse_image_header(const struct image_header *header)
>  		debug("mkimage signature not found - ih_magic = %x\n",
>  			header->ih_magic);
>  		/* Let's assume U-Boot will not be more than 200 KB */
> +#ifdef CONFIG_SYS_MONITOR_LEN
> +		spl_image.size = CONFIG_SYS_MONITOR_LEN;
> +#else
>  		spl_image.size = 200 * 1024;
> +#endif

Yes, I noticed this 200 KiB setting as well. But it seems that this
".size" variable is not referenced at all. Or am I missing something? If
this is correct, then we should probably remove setting it completely.

What do you think?

Thanks,
Stefan