public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] atmel: sam9g10: correct the text base and move into config.mk
Date: Thu, 23 Aug 2012 12:36:37 +0200	[thread overview]
Message-ID: <503607B5.5090401@gmail.com> (raw)
In-Reply-To: <1345714491-28805-1-git-send-email-voice.shen@atmel.com>

Dear Bo Shen,

On 23.08.2012 11:34, Bo Shen wrote:
> This patch correct the text base for at91sam9g10ek board
> Move the text base define to config.mk
> 
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
>  board/atmel/at91sam9261ek/config.mk |    1 +
>  include/configs/at91sam9261ek.h     |    1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  create mode 100644 board/atmel/at91sam9261ek/config.mk
> 
> diff --git a/board/atmel/at91sam9261ek/config.mk b/board/atmel/at91sam9261ek/config.mk
> new file mode 100644
> index 0000000..e554a45
> --- /dev/null
> +++ b/board/atmel/at91sam9261ek/config.mk
> @@ -0,0 +1 @@
> +CONFIG_SYS_TEXT_BASE = 0x23f00000

NAK, these configuration should go into the board config header or maybe
the boards.cfg.
For this board please read commit f7aea46d6ad9c257d2fbea7238cc8796aaa733f1

Another point is, the 23f00000 is (possibly) not far enough from
position the start.S code will relocate the u-boot (depends on size of
gd_t, bd_t, malloc arena, some special env, a.s.o). That was changed in
f7aea46 by intention. Please fix at91bootstrap instead (or start
integrating at91 for common SPL framework in u-boot; still on my plan
for this year but I couldn't manage to start until yet).

> diff --git a/include/configs/at91sam9261ek.h b/include/configs/at91sam9261ek.h
> index 014437b..718ac60 100644
> --- a/include/configs/at91sam9261ek.h
> +++ b/include/configs/at91sam9261ek.h
> @@ -52,7 +52,6 @@
>  #define CONFIG_DISPLAY_CPUINFO
>  
>  #define CONFIG_ATMEL_LEGACY
> -#define CONFIG_SYS_TEXT_BASE		0x21f00000
>  
>  /*
>   * Hardware drivers
> 

  reply	other threads:[~2012-08-23 10:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23  9:34 [U-Boot] [PATCH] atmel: sam9g10: correct the text base and move into config.mk Bo Shen
2012-08-23 10:36 ` Andreas Bießmann [this message]
2012-08-24  1:51   ` Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503607B5.5090401@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox