[U-Boot] [PATCHv2 1/2] mpc85xx: Initial SP alignment is wrong.

Scott Wood
2012-08-23T16:53:14Z

On 08/23/2012 02:21 AM, Joakim Tjernlund wrote:
> Andy Fleming <afleming@gmail.com> wrote on 2012/08/22 23:08:45:
>>
>> On Mon, Jul 23, 2012 at 3:58 PM, Joakim Tjernlund
>> <Joakim.Tjernlund@transmode.se> wrote:
>>> PowerPC mandates SP to be 16 bytes aligned.
>>> Furthermore, a stack frame is added, pointing to the reset vector
>>> which may in the way when gdb is walking the stack because
>>> the reset vector may not accessible depending on emulator settings.
>>> Also use a temp register so gdb doesn't pick up intermediate values.
>>>
>>> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
>>> ---
>>>
>>> v2 - Address Scott Wood's comments
>>> arch/powerpc/cpu/mpc85xx/start.S | 16 +++++-----------
>>> 1 files changed, 5 insertions(+), 11 deletions(-)
>>>
>>> diff --git arch/powerpc/cpu/mpc85xx/start.S arch/powerpc/cpu/mpc85xx/start.S
>>
>>
>> Why are your patches different from everyone else's? When I try to
>> apply this, I get errors because it can't find
>> "powerpc/cpu/mpc85xx...". git am leaves off the first directory,
>> because the usual practice is to send patches with these filenames:
>
> Ahh, recently I set (in ny git config):
> [diff]
> noprefix = true
> because I got tired off stripping off that prefix each time I cut and
> paste file names into emacs and similar.
>
> Seems like git really likes to see that prefix when applying patches.
> Don't know if git could learn not to complain about missing prefix?

It's not just git, but also direct use of the patch command when a patch
fails to apply cleanly. A user shouldn't have to inspect a patch to
determine whether to use -p0 or -p1. -p1 is standard.

How often do you copy and paste filenames out of your own patches?

-Scott