[U-Boot] [PATCHv2 1/2] mpc85xx: Initial SP alignment is wrong.

Andy Fleming
2012-08-16T23:40:28Z

I will pull them. Possibly tomorrow. I'm currently buried in other work, but Friday is supposed to be my U-Boot Custodian day. :)

Andy
On Aug 15, 2012, at 12:13 PM, Scott Wood wrote:

> On 08/15/2012 02:10 AM, Joakim Tjernlund wrote:
>> Kumar Gala <galak@kernel.crashing.org> wrote on 2012/08/14 23:28:45:
>>>
>>>
>>> On Jul 23, 2012, at 3:58 PM, Joakim Tjernlund wrote:
>>>
>>>> PowerPC mandates SP to be 16 bytes aligned.
>>>> Furthermore, a stack frame is added, pointing to the reset vector
>>>> which may in the way when gdb is walking the stack because
>>>> the reset vector may not accessible depending on emulator settings.
>>>> Also use a temp register so gdb doesn't pick up intermediate values.
>>>>
>>>> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
>>>> ---
>>>>
>>>> v2 - Address Scott Wood's comments
>>>> arch/powerpc/cpu/mpc85xx/start.S | 16 +++++-----------
>>>> 1 files changed, 5 insertions(+), 11 deletions(-)
>>>
>>> Acked-by: Kumar Gala <galak@kernel.crashing.org>
>>
>> Thanks Kumar
>>
>> Will you pick up?
>> [PATCHv2 2/2] powerpc: Stack Pointer not properly aligned
>>
>> It is not 85xx specific but for all PowerPC
>
> I don't think Kumar has a U-Boot tree to pull it into. There's no
> general PPC custodian. Probably both patches should go via Andy.
>
> -Scott
>