From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc
Date: Thu, 23 Aug 2012 20:16:17 +0200 [thread overview]
Message-ID: <50367371.7080206@denx.de> (raw)
In-Reply-To: <503663EE.9000902@ti.com>
On 08/23/2012 07:10 PM, Tom Rini wrote:
>> +#ifdef CONFIG_ARM
>> /* Define global data structure pointer to it*/
>> gd_t gdata __attribute__ ((section(".data")));
>> +#endif
>
> So you handle cleaning up the BSS differently, interesting. I'm going
> to see if that would work for ARM too..
Yes. Might be that I missed something though. I'll re-check tomorrow.
> [snip]
>> @@ -89,7 +106,11 @@ void spl_parse_image_header(const struct image_header *header)
>> spl_image.size = __be32_to_cpu(header->ih_size) + header_size;
>> spl_image.entry_point = __be32_to_cpu(header->ih_load);
>> /* Load including the header */
>> +#ifdef CONFIG_ARM
>> spl_image.load_addr = spl_image.entry_point - header_size;
>> +#else
>> + spl_image.load_addr = __be32_to_cpu(header->ih_load);
>> +#endif
>
> This isn't an ARM-ism but is instead because spl_nor.c isn't offsetting
> where the header is like mmc/nand/ymodem do, yes? Would it be possible
> to make spl_nor.c behave like the others? One of the reasons I ask is
> I'm looking at a NOR chip on my desk...
I was wondering about this line as well. Please explain: Why can't ARM
just use header->ih_load as load_addr?
Thanks,
Stefan
next prev parent reply other threads:[~2012-08-23 18:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 8:12 [U-Boot] [PATCH 0/6] SPL: Port SPL framework to powerpc Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 1/6] SPL: Add NOR flash booting support Stefan Roese
2012-08-23 15:07 ` Tom Rini
2012-08-23 15:19 ` Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 2/6] powerpc: Extract EPAPR_MAGIC constants into processor.h Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc Stefan Roese
2012-08-23 17:10 ` Tom Rini
2012-08-23 18:16 ` Stefan Roese [this message]
2012-08-23 19:31 ` Tom Rini
2012-08-24 8:17 ` Stefan Roese
2012-08-24 10:17 ` Heiko Schocher
2012-08-24 10:56 ` Stefan Roese
2012-08-24 11:13 ` Stefan Roese
2012-08-24 11:49 ` Daniel Schwierzeck
2012-08-24 14:11 ` Stefan Roese
2012-08-24 15:29 ` Daniel Schwierzeck
2012-08-24 16:06 ` Stefan Roese
2012-08-24 16:42 ` Daniel Schwierzeck
2012-08-24 17:24 ` Stefan Roese
2012-08-24 22:13 ` Daniel Schwierzeck
2012-08-24 19:15 ` Tom Rini
2012-08-25 8:48 ` Stefan Roese
2012-08-23 21:39 ` Tom Rini
2012-08-24 7:01 ` Stefan Roese
2012-08-24 15:55 ` Tom Rini
2012-08-24 16:07 ` Stefan Roese
2012-08-24 16:19 ` Tom Rini
2012-08-24 17:21 ` Stefan Roese
2012-08-23 21:52 ` Tom Rini
2012-08-24 7:03 ` Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 4/6] env: Extract getenv_f() into separate source file Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 5/6] mpc5200: Add SPL support Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 6/6] mpc5200: Add a3m071 board support Stefan Roese
2012-08-23 21:53 ` [U-Boot] [PATCH 0/6] SPL: Port SPL framework to powerpc Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50367371.7080206@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox