From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc
Date: Fri, 24 Aug 2012 12:56:17 +0200 [thread overview]
Message-ID: <50375DD1.80508@denx.de> (raw)
In-Reply-To: <503754D6.1050405@denx.de>
Hi Heiko,
On 08/24/2012 12:17 PM, Heiko Schocher wrote:
>> BTW: There also seems to be a bug in some of the SPL loaders:
>>
>> For example in drivers/mtd/nand/nand_spl_load.c:
>>
>> ...
>> if (header->ih_os == IH_OS_LINUX) {
>> /* happy - was a linux */
>> nand_spl_load_image(CONFIG_SYS_NAND_SPL_KERNEL_OFFS,
>> spl_image.size, (void *)spl_image.load_addr);
>>
>> The problem here is that the last 64 bytes of the image are not
>> copied to SDRAM. Since the header is copied which is not included
>> in the spl_image.size variable.
Okay. I just noticed that it's not a bug. spl_image.size is set to
header->ih_size + header_size. So 64 is added and the complete payload
is copied.
I still would like to move to my suggestion to not copy the header and
use the mkimage header values ih_load and ih_ep directly. Right now I
don't see any showstopper for doing it this way. I'll send a patch to
change this shortly (if everything works out).
Stay tuned...
Thanks,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2012-08-24 10:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 8:12 [U-Boot] [PATCH 0/6] SPL: Port SPL framework to powerpc Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 1/6] SPL: Add NOR flash booting support Stefan Roese
2012-08-23 15:07 ` Tom Rini
2012-08-23 15:19 ` Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 2/6] powerpc: Extract EPAPR_MAGIC constants into processor.h Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc Stefan Roese
2012-08-23 17:10 ` Tom Rini
2012-08-23 18:16 ` Stefan Roese
2012-08-23 19:31 ` Tom Rini
2012-08-24 8:17 ` Stefan Roese
2012-08-24 10:17 ` Heiko Schocher
2012-08-24 10:56 ` Stefan Roese [this message]
2012-08-24 11:13 ` Stefan Roese
2012-08-24 11:49 ` Daniel Schwierzeck
2012-08-24 14:11 ` Stefan Roese
2012-08-24 15:29 ` Daniel Schwierzeck
2012-08-24 16:06 ` Stefan Roese
2012-08-24 16:42 ` Daniel Schwierzeck
2012-08-24 17:24 ` Stefan Roese
2012-08-24 22:13 ` Daniel Schwierzeck
2012-08-24 19:15 ` Tom Rini
2012-08-25 8:48 ` Stefan Roese
2012-08-23 21:39 ` Tom Rini
2012-08-24 7:01 ` Stefan Roese
2012-08-24 15:55 ` Tom Rini
2012-08-24 16:07 ` Stefan Roese
2012-08-24 16:19 ` Tom Rini
2012-08-24 17:21 ` Stefan Roese
2012-08-23 21:52 ` Tom Rini
2012-08-24 7:03 ` Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 4/6] env: Extract getenv_f() into separate source file Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 5/6] mpc5200: Add SPL support Stefan Roese
2012-08-23 8:12 ` [U-Boot] [PATCH 6/6] mpc5200: Add a3m071 board support Stefan Roese
2012-08-23 21:53 ` [U-Boot] [PATCH 0/6] SPL: Port SPL framework to powerpc Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50375DD1.80508@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox