From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mx5:Use IMX_GPIO_NR macro
Date: Mon, 27 Aug 2012 19:42:09 +0200 [thread overview]
Message-ID: <503BB171.9080800@denx.de> (raw)
In-Reply-To: <503BAC11.5010707@gmail.com>
On 27/08/2012 19:19, Ashok wrote:
> From 14ef1037b2b535c30c62c8bf1483f9f66960e4e8 Mon Sep 17 00:00:00 2001
> From: Ashok Kumar Reddy <ashokkourla2000@gmail.com>
> Date: Mon, 27 Aug 2012 22:29:20 +0530
> Subject: [PATCH v2] mx5:Use IMX_GPIO_NR macro
>
> Signed-off-by: Ashok Kumar Reddy <ashokkourla2000@gmail.com>
> ---
Hi Ashok,
> Changes from v1:
> -Remove checkpatch errors
>
> board/freescale/mx51evk/mx51evk.c | 12 ++++++------
> board/freescale/mx53ard/mx53ard.c | 8 ++++----
> board/freescale/mx53evk/mx53evk.c | 8 ++++----
> board/freescale/mx53loco/mx53loco.c | 8 ++++----
> board/freescale/mx53smd/mx53smd.c | 4 ++--
> 5 files changed, 20 insertions(+), 20 deletions(-)
>
I still get a couple of errors from checkpatch. Can you fix them ?
ERROR: trailing whitespace
#86: FILE: board/freescale/mx53ard/mx53ard.c:99:
+^I^Iret = !gpio_get_value(IMX_GPIO_NR(1, 4)); $
ERROR: trailing whitespace
#106: FILE: board/freescale/mx53evk/mx53evk.c:222:
+^I^Iret = !gpio_get_value(IMX_GPIO_NR(3, 13)); $
total: 2 errors, 0 warnings, 95 lines checked
Regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2012-08-27 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 17:19 [U-Boot] [PATCH v2] mx5:Use IMX_GPIO_NR macro Ashok
2012-08-27 17:42 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503BB171.9080800@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox