[U-Boot] [PATCH v4 11/20] ARM: SPL: Clean up spl.c / spl_nand.c slightly

Tom Rini
2012-08-27T20:17:36Z

On 08/27/2012 12:34 PM, Sughosh Ganu wrote:
> On Fri Aug 24, 2012 at 04:58:25PM -0700, Tom Rini wrote:
>> - Remove includes we don't need
>> - Switch some printf statements to puts
>> - Convert some printf statements to debug, introduce new puts statements
>> - In most cases saying just "No mkimage signature, assuming
>> u-boot.bin" or similar is sufficient. This also means the non-DEBUG
>> case doesn't need printf, in the core of SPL.
>> - The other case here is that PLAIN_VERSION provided what we wanted
>> already, so just use it.
>>
>> Signed-off-by: Tom Rini <trini@ti.com>
>> ---
>
> <snip>
>
>> @@ -99,9 +96,9 @@ void spl_parse_image_header(const struct image_header *header)
>> spl_image.name, spl_image.load_addr, spl_image.size);
>> } else {
>> /* Signature not found - assume u-boot.bin */
>> - printf("mkimage signature not found - ih_magic = %x\n",
>> + puts("mkimage signature not found, assuming u-boot.bin ..\n");
>
> Just a nit. Can the above be made a debug statement instead, like how
> it was earlier. I guess it's a bit superfluous -- also the other case
> just has a debug. Don't have a strong opinion about this though, just
> find it a bit annoying that this gets printed at every boot :).

I've of two minds here. On the one hand, in the omap-common version we
always had a print here and part of the point is that you ought to be
writing u-boot.img. On the other hand, making this a debug saves us
space :)

--
Tom