public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 18/25] SPL: NAND: Move arch/arm/cpu/armv7/omap-common/spl_nand.c to common/spl
Date: Mon, 27 Aug 2012 19:38:21 -0500	[thread overview]
Message-ID: <503C12FD.4070303@freescale.com> (raw)
In-Reply-To: <503C1284.5060307@ti.com>

On 08/27/2012 07:36 PM, Tom Rini wrote:
> On 08/27/2012 04:22 PM, Scott Wood wrote:
>> On 08/27/2012 06:18 PM, Tom Rini wrote:
>>> diff --git a/common/spl/Makefile b/common/spl/Makefile
>>> index b61b438..7a77cd3 100644
>>> --- a/common/spl/Makefile
>>> +++ b/common/spl/Makefile
>>> @@ -16,6 +16,7 @@ LIB	= $(obj)libspl.o
>>>  ifdef CONFIG_SPL_BUILD
>>>  COBJS-$(CONFIG_SPL_FRAMEWORK) += spl.o
>>>  COBJS-$(CONFIG_SPL_YMODEM_SUPPORT) += spl_ymodem.o
>>> +COBJS-$(CONFIG_SPL_NAND_SIMPLE) += spl_nand.o
>>
>> Please use a separate config symbol for this.
> 
> No need, common/spl/libspl.o is dependent on CONFIG_SPL_FRAMEWORK

Do you not want it to be possible for hardware which cannot use
CONFIG_SPL_NAND_SIMPLE to use this?

-Scott

  reply	other threads:[~2012-08-28  0:38 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-27 23:18 [U-Boot] [PATCH v5 0/25] ARM: SPL: Make more generic, merge DaVinci and OMAP Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 01/25] Makefile: Move SPL files to clobber, remove from clean Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 02/25] spl_mmc: Make FAT checks / calls guarded with CONFIG_SPL_FAT_SUPPORT Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 03/25] omap-common: SPL: Add CONFIG_SPL_DISPLAY_PRINT / spl_display_print() Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 04/25] omap-common: Fix typo in save_boot_params() in lowlevel_init.S Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 05/25] ARM: SPL: Rename omap_boot_device to spl_boot_device Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 06/25] ARM: SPL: Rename omap_boot_mode to spl_boot_mode() Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 07/25] ARM: SPL: Remove NAND_MODE_HW_ECC from spl_nand.c Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 08/25] ARM: SPL: Only call mem_malloc_init if configured Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 09/25] ARM: SPL: Add <asm/spl.h> and <asm/arch/spl.h> Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 10/25] ARM: SPL: Make spl_mmc.c more generic Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 11/25] ARM: SPL: Clean up spl.c / spl_nand.c slightly Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 12/25] ARM: SPL: Start hooking in the current SPI SPL support Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 13/25] ARM: SPL: Move gpmc_init() to spl_board_init() Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 14/25] SPL: Move the omap SPL framework to common/spl Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 15/25] SPL: Create arch/arm/lib/spl.c for board_init_f and jump_to_image_linux Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 16/25] SPL: do not use fix value for u-boot size Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 17/25] SPL: Use image_get_xxx() functions to access header values Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 18/25] SPL: NAND: Move arch/arm/cpu/armv7/omap-common/spl_nand.c to common/spl Tom Rini
2012-08-27 23:22   ` Scott Wood
2012-08-28  0:36     ` Tom Rini
2012-08-28  0:38       ` Scott Wood [this message]
2012-08-28  0:53         ` Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 19/25] ARM: SPL: Convert davinci to CONFIG_SPL_FRAMEWORK Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 20/25] da850: Add README.da850 Tom Rini
2012-08-28  6:56   ` Christian Riesch
2012-08-28  7:27   ` Christian Riesch
2012-08-28 14:59     ` Tom Rini
2012-08-29  7:33   ` Prabhakar Lad
2012-08-27 23:18 ` [U-Boot] [PATCH v5 21/25] SPL: Add NOR flash booting support Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 22/25] SPL: Add option to skip copying of the mkimage header Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 23/25] SPL: SPI: Enhance spi_spl_load to match the other load functions Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 24/25] SPL: Make un-supported boot device puts a debug instead Tom Rini
2012-08-27 23:18 ` [U-Boot] [PATCH v5 25/25] SPL: Rework how we inform about un-headered images Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503C12FD.4070303@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox