From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 04/12] SPL: Add NOR flash booting support
Date: Tue, 28 Aug 2012 10:32:17 +0200 [thread overview]
Message-ID: <503C8211.9000907@denx.de> (raw)
In-Reply-To: <503BB58D.2080508@ti.com>
On 08/27/2012 07:59 PM, Tom Rini wrote:
> On 08/27/2012 10:29 AM, Daniel Schwierzeck wrote:
>> Hi Stefan,
>>
>> 2012/8/27 Stefan Roese <sr@denx.de>:
>>> SPL NOR flash booting support is quite simple. Only copying of the
>>> images is needed.
>>>
>>> On MPC5xxx we need to make sure to only use the standard memcpy()
>>> implementation and not the MPC5xxx specific one. As the MPC5xxx
>>> version has some complexity which is not needed for this SPL
>>> booting.
>>>
>>> Signed-off-by: Stefan Roese <sr@denx.de>
> [snip]
>>> +/*
>>> + * Don't use the special MPC5xxx memcpy implementation, only use
>>> + * the standard one.
>>> + */
>>> +#if defined(CONFIG_MPC512X) || defined(CONFIG_MPC5200)
>>> +extern void *__memcpy(void *, const void *, size_t);
>>> +#define memcpy __memcpy
>>> +#endif
>>
>> can't we move this to arch-specifc spl code?
>> I think arch/CPU/SoC specific definitions should be avoided in new
>> generic frameworks.
>
> This is a good point. And I think we can further tweak this by
> modifying arch/powerpc/lib/Makefile to just not build memcpy_5200.c for
> CONFIG_SPL_BUILD. So lets go with that, and I'll just fixup my local copy.
Good idea. I'll change the powerpc Makefile accordingly.
Thanks,
Stefan
next prev parent reply other threads:[~2012-08-28 8:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 10:50 [U-Boot] [PATCH v2 0/12] SPL: Port SPL framework to powerpc Stefan Roese
2012-08-27 10:50 ` [U-Boot] [PATCH v2 01/12] SPL: Fix build problems on ARM with new SPL framework Stefan Roese
2012-08-27 16:30 ` Tom Rini
2012-08-27 10:50 ` [U-Boot] [PATCH v2 02/12] SPL: Use image_get_xxx() functions to access header values Stefan Roese
2012-08-27 16:31 ` Tom Rini
2012-08-27 10:50 ` [U-Boot] [PATCH v2 03/12] SPL: Add option to skip copying of the mkimage header Stefan Roese
2012-08-27 10:50 ` [U-Boot] [PATCH v2 04/12] SPL: Add NOR flash booting support Stefan Roese
2012-08-27 16:45 ` Tom Rini
2012-08-27 17:29 ` Daniel Schwierzeck
2012-08-27 17:59 ` Tom Rini
2012-08-28 8:32 ` Stefan Roese [this message]
2012-08-27 10:51 ` [U-Boot] [PATCH v2 05/12] powerpc: Extract EPAPR_MAGIC constants into processor.h Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 06/12] SPL: Port SPL framework to powerpc Stefan Roese
2012-08-27 16:27 ` Tom Rini
2012-08-28 8:21 ` Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 07/12] env: Extract getenv_f() into separate source file Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 08/12] mpc5200: Add SPL support Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 09/12] mpc5200: Add a3m071 board support Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 10/12] fdt: cmd_fdt: Call fdt_chosen() from "fdt boardsetup" Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 11/12] Makefile: Add possibility to set entry-point for u-boot.img Stefan Roese
2012-08-27 10:51 ` [U-Boot] [PATCH v2 12/12] Makefile: Add target for combined spl/u-boot.bin & u-boot.img Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503C8211.9000907@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox