public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jeroen Hofstee <dasuboot@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 7/8] video: drop duplicate set of DISPC_CONFIG register
Date: Tue, 28 Aug 2012 12:40:30 +0200	[thread overview]
Message-ID: <503CA01E.4090909@myspectrum.nl> (raw)
In-Reply-To: <1346140007-9563-7-git-send-email-sbabic@denx.de>

Hi Stefano,

On 08/28/2012 09:46 AM, Stefano Babic wrote:
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>   drivers/video/omap3_dss.c |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/omap3_dss.c b/drivers/video/omap3_dss.c
> index 6686718..5fcc0fb 100644
> --- a/drivers/video/omap3_dss.c
> +++ b/drivers/video/omap3_dss.c
> @@ -112,7 +112,6 @@ void omap3_dss_panel_config(const struct panel_config *panel_cfg)
>   	writel(panel_cfg->pol_freq, &dispc->pol_freq);
>   	writel(panel_cfg->divisor, &dispc->divisor);
>   	writel(panel_cfg->lcd_size, &dispc->size_lcd);
> -	writel(panel_cfg->load_mode << FRAME_MODE_SHIFT, &dispc->config);
>   	writel(panel_cfg->panel_type << TFTSTN_SHIFT |
>   		panel_cfg->data_lines << DATALINES_SHIFT, &dispc->control);
>   	writel(panel_cfg->panel_color, &dispc->default_color0);
The beagle board doesn't have a framebuffer, but uses the panel color
only. So only the part till if (!panel_cfg->frame_buffer) is used by the 
beagle
board, so the other should be removed.

And perhaps change the FRAME_MODE_SHIFT to LOADMODE_SHIFT
(both defined as 1 though).

Regards,
Jeroen

  reply	other threads:[~2012-08-28 10:40 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28  7:46 [U-Boot] [PATCH v1 1/8] OMAP3: tam3517: add function to read MAC from EEPROM Stefano Babic
2012-08-28  7:46 ` [U-Boot] [PATCH v1 2/8] OMAP3: twister : get MAC address " Stefano Babic
2012-08-28  7:46 ` [U-Boot] [PATCH v1 3/8] OMAP3: mt_ventoux: Correct board pinmux Stefano Babic
2012-08-28  7:46 ` [U-Boot] [PATCH v1 4/8] OMAP3: mt_ventoux: activate GPIO4 Stefano Babic
2012-08-28  7:46 ` [U-Boot] [PATCH v1 5/8] OMAP3: mt_ventoux: read MAC address from EEPROM Stefano Babic
2012-08-28  7:46 ` [U-Boot] [PATCH v1 6/8] OMAP3: mt_ventoux: disable the buzzer at start-up Stefano Babic
2012-08-28  7:46 ` [U-Boot] [PATCH v1 7/8] video: drop duplicate set of DISPC_CONFIG register Stefano Babic
2012-08-28 10:40   ` Jeroen Hofstee [this message]
2012-08-28 10:59     ` Stefano Babic
2012-08-28  7:46 ` [U-Boot] [PATCH v1 8/8] OMAP3: mt_ventoux: added video support Stefano Babic
2012-08-28  8:11   ` Heiko Schocher
2012-08-28  8:28     ` Stefano Babic
2012-08-28  8:47       ` Jeroen Hofstee
2012-08-28 11:05         ` Stefano Babic
2012-08-28 12:21 ` [U-Boot] [PATCH v2 0/9] This patchset updates boards based on the TAM3517 SOM Stefano Babic
2012-08-28 12:21   ` [U-Boot] [PATCH v2 1/9] OMAP3: tam3517: add function to read MAC from EEPROM Stefano Babic
2012-08-28 12:21   ` [U-Boot] [PATCH v2 2/9] OMAP3: twister : get MAC address " Stefano Babic
2012-08-28 12:21   ` [U-Boot] [PATCH v2 3/9] OMAP3: mt_ventoux: Correct board pinmux Stefano Babic
2012-08-28 12:21   ` [U-Boot] [PATCH v2 4/9] OMAP3: mt_ventoux: activate GPIO4 Stefano Babic
2012-08-28 12:21   ` [U-Boot] [PATCH v2 5/9] OMAP3: mt_ventoux: read MAC address from EEPROM Stefano Babic
2012-08-28 12:21   ` [U-Boot] [PATCH v2 6/9] OMAP3: mt_ventoux: disable the buzzer at start-up Stefano Babic
2012-08-28 12:21   ` [U-Boot] [PATCH v2 7/9] video: drop duplicate set of DISPC_CONFIG register Stefano Babic
2012-08-28 20:49     ` Jeroen Hofstee
2012-08-28 12:21   ` [U-Boot] [PATCH v2 8/9] OMAP3: video: add macros to set display parameters Stefano Babic
2012-08-28 14:01     ` Heiko Schocher
2012-08-28 22:22     ` Jeroen Hofstee
2012-08-28 22:29       ` Tom Rini
2012-08-29  7:40         ` Stefano Babic
2012-08-28 12:21   ` [U-Boot] [PATCH v2 9/9] OMAP3: mt_ventoux: added video support Stefano Babic
2012-08-29 11:21 ` [U-Boot] [PATCH v3 0/9] This patchset updates boards based on the TAM3517 SOM Stefano Babic
2012-08-29 11:21   ` [U-Boot] [PATCH v3 1/9] OMAP3: tam3517: add function to read MAC from EEPROM Stefano Babic
2012-08-29 11:22   ` [U-Boot] [PATCH v3 2/9] OMAP3: twister : get MAC address " Stefano Babic
2012-08-29 11:22   ` [U-Boot] [PATCH v3 3/9] OMAP3: mt_ventoux: Correct board pinmux Stefano Babic
2012-08-29 11:22   ` [U-Boot] [PATCH v3 4/9] OMAP3: mt_ventoux: activate GPIO4 Stefano Babic
2012-08-29 11:22   ` [U-Boot] [PATCH v3 5/9] OMAP3: mt_ventoux: read MAC address from EEPROM Stefano Babic
2012-08-29 11:22   ` [U-Boot] [PATCH v3 6/9] OMAP3: mt_ventoux: disable the buzzer at start-up Stefano Babic
2012-08-29 11:22   ` [U-Boot] [PATCH v3 7/9] video: drop duplicate set of DISPC_CONFIG register Stefano Babic
2012-08-29 11:22   ` [U-Boot] [PATCH v3 8/9] OMAP3: video: add macros to set display parameters Stefano Babic
2012-08-29 11:22   ` [U-Boot] [PATCH v3 9/9] OMAP3: mt_ventoux: added video support Stefano Babic
2012-08-29 15:13   ` [U-Boot] [PATCH v3 0/9] This patchset updates boards based on the TAM3517 SOM Tom Rini
2012-08-31 23:07     ` Tom Rini
2012-08-29 16:28   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503CA01E.4090909@myspectrum.nl \
    --to=dasuboot@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox