public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL
Date: Wed, 29 Aug 2012 15:28:50 -0700	[thread overview]
Message-ID: <503E97A2.9060709@ti.com> (raw)
In-Reply-To: <CANr=Z=YJJH=OrPo4V6_4acFL07W1MirATJ1a_eNrNtTrwze=xA@mail.gmail.com>

On 08/29/2012 02:25 PM, Joe Hershberger wrote:

[snip]
>>  #include <common.h>
>> +#ifdef CONFIG_SPL_BUILD
>> +/* SPL needs only BOOTP + TFTP so undefine other stuff to save space */
>> +#undef CONFIG_CMD_DHCP
>> +#undef CONFIG_CMD_CDP
>> +#undef CONFIG_CMD_DNS
>> +#undef CONFIG_CMD_LINK_LOCAL
>> +#undef CONFIG_CMD_NFS
>> +#undef CONFIG_CMD_PING
>> +#undef CONFIG_CMD_RARP
>> +#undef CONFIG_CMD_SNTP
>> +#undef CONFIG_CMD_TFTPPUT
>> +#undef CONFIG_CMD_TFTPSRV
>> +#endif
> 
> Is this the best place to do this?  Seems it would be clearer to
> modify config_cmd_default.h or add a config_cmd_spl.h that will
> undefine them, and include that.

I was thinking about that too, include/config_cmd_spl.h should probably
be how this happens.

-- 
Tom

  reply	other threads:[~2012-08-29 22:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-05 21:21 [U-Boot] [PATCH v4 0/5] OMAP: SPL networking support Ilya Yanok
2012-08-05 21:21 ` [U-Boot] [PATCH v4 1/5] net/bootp: add VCI support for BOOTP also Ilya Yanok
2012-08-10 17:57   ` Ilya Yanok
2012-08-29 21:01   ` Joe Hershberger
2012-08-05 21:21 ` [U-Boot] [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined Ilya Yanok
2012-08-05 22:36   ` Tom Rini
2012-08-06 15:10     ` Ilya Yanok
2012-08-06 15:30       ` Tom Rini
2012-08-06 15:31         ` Ilya Yanok
2012-08-06 17:10           ` Tom Rini
2012-08-06 19:15             ` Ilya Yanok
2012-08-06 20:52               ` Tom Rini
2012-08-06 21:11                 ` Ilya Yanok
2012-08-07  8:12                   ` Ilya Yanok
2012-08-05 21:21 ` [U-Boot] [PATCH v4 3/5] OMAP: spl: call timer_inti() from SPL Ilya Yanok
2012-08-05 22:35   ` Tom Rini
2012-08-06 15:02     ` Ilya Yanok
2012-08-06 15:11       ` Tom Rini
2012-08-06 18:49   ` [U-Boot] [PATCH] am33xx: Remove redundant timer config Tom Rini
2012-08-05 21:21 ` [U-Boot] [PATCH v4 4/5] OMAP: networking support for SPL Ilya Yanok
2012-08-07  8:07   ` [U-Boot] [PATCH v5 " Ilya Yanok
2012-08-29 21:25     ` Joe Hershberger
2012-08-29 22:28       ` Tom Rini [this message]
2012-09-17  9:55       ` Ilya Yanok
2012-09-17 17:04         ` Tom Rini
2012-09-17 17:54           ` Ilya Yanok
2012-09-17 18:07             ` Tom Rini
2012-09-17 18:10               ` Ilya Yanok
2012-09-17 18:16                 ` Ilya Yanok
2012-09-17 18:19                 ` Tom Rini
2012-09-17 18:36         ` Ilya Yanok
2012-08-05 21:21 ` [U-Boot] [PATCH v4 5/5] am335x_evm: enable networking in SPL Ilya Yanok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503E97A2.9060709@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox