From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 30 Aug 2012 10:46:09 -0700 Subject: [U-Boot] [PATCHv1] ARM: Add Altera SOCFPGA Cyclone5 In-Reply-To: <503FA436.7090201@ti.com> References: <201208230026.53389.marex@denx.de> <20120823011353.GB3476@bill-the-cat> <20120823104342.GA28214@elf.ucw.cz> <5037D383.2080105@ti.com> <20120825120537.GA29569@elf.ucw.cz> <503B98ED.3090407@ti.com> <20120829134154.GA13606@elf.ucw.cz> <20120829182645.GB3450@bill-the-cat> <20120829232153.GA23417@elf.ucw.cz> <503EAD32.90806@ti.com> <20120830171842.GD5980@elf.ucw.cz> <503FA436.7090201@ti.com> Message-ID: <503FA6E1.7010903@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/30/2012 10:34 AM, Tom Rini wrote: > On 08/30/2012 10:18 AM, Pavel Machek wrote: > >>>> + * miscellaneous platform dependent initialisations >>>> + */ >>>> +int misc_init_r(void) >>>> +{ >>>> + /* Set to "n" for not verifying the uImage */ >>>> + setenv("verify", "n"); >>>> + return 0; >>>> +} >>> >>> Not good to enforce policy like this. Just don't set it in the config >>> file by default and let users do as they need. >> >> Hmm. I moved it to CONFIG_EXTRA_ENV_SETTINGS as done by for eample >> u8500_href.h. Is that ok? > > It defaults to no, I believe is the thing (so yes, there's a few bad > examples out there including, urk, one that I own). I take it back, yes is the default, so yes, doing CONFIG_EXTRA_ENV_SETTINGS with verify=no is correct. -- Tom