From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dlmalloc: remove manual reloc alias warning
Date: Sat, 01 Sep 2012 15:20:17 +0200 [thread overview]
Message-ID: <50420B91.3080908@googlemail.com> (raw)
In-Reply-To: <20120901120231.B9C2C205615@gemini.denx.de>
Dera Wolfgang Denk,
On 01.09.2012 14:02, Wolfgang Denk wrote:
> Dear Andreas,
>
> In message <20120901101031.2DA15205615@gemini.denx.de> I wrote:
>>
>> i. e. this has the offset 2 added twice, so it is missing the first
>> two real entries, env writing beyond the end of the array.
>
> Please ignore me. Seems my brain is still in vacation mode.
>
> However, I really wonder why you say this code would be causing
> runtime errors for you:
>
>> mbinptr *p = &av_[2];
>> int i;
>>
>> for (i = 2; i < ARRAY_SIZE(av_); ++i)
>> *p = (mbinptr)((ulong)*p + gd->reloc_off);
>
> It looks good to me.
Well, I did not investigate it further, but I can do this weekend (after
merging/testing/pull request the atmel arm stuff). Hopefully we get a
solution for the annoying alias warning in upcoming release.
Best regards
Andreas Bie?mann
> Can you please add some debug printf()s to find out how the old code
> and this one differ in their results?
>
> Best regards,
>
> Wolfgang Denk
>
prev parent reply other threads:[~2012-09-01 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 9:02 [U-Boot] [PATCH] dlmalloc: remove manual reloc alias warning Andreas Bießmann
2012-08-13 14:54 ` Mike Frysinger
2012-08-13 15:14 ` Andreas Bießmann
2012-08-13 15:31 ` Andreas Bießmann
2012-08-14 8:50 ` Andreas Bießmann
2012-08-15 0:15 ` Simon Glass
2012-08-15 6:29 ` Andreas Bießmann
2012-09-01 10:10 ` Wolfgang Denk
2012-09-01 12:02 ` Wolfgang Denk
2012-09-01 13:20 ` Andreas Bießmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50420B91.3080908@googlemail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).