From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] disk: part_efi: parse and store partition UUID
Date: Sun, 02 Sep 2012 19:06:32 -0700 [thread overview]
Message-ID: <504410A8.3030707@wwwdotorg.org> (raw)
In-Reply-To: <20120902174527.57C8A203B2F@gemini.denx.de>
On 09/02/2012 10:45 AM, Wolfgang Denk wrote:
> Dear Stephen Warren,
>
> In message <1345158942-31512-1-git-send-email-swarren@wwwdotorg.org> you wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Each EFI partition table entry contains a UUID. Extend U-Boot's struct
>> disk_partition to be able to store this information, and modify
>> get_partition_info_efi() to fill it in.
>>
>> The implementation of uuid_string() was stolen from the Linux kernel.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Can we please make this addition dependent on EFI support being
> enabled? Otherwise the increased memory footprint will hit all users,
> even if they never use EFI at all.
(I assume you're talking about the change to the partition info
structure, since IIRC all the other code was already in either the EFI
partition code already, or a new command under its own ifdef).
I'm also planning a patch that fills in this UUID field for MBR/DOS
partition tables too. That'd require the ifdef to check 2 different
config symbols, and perhaps more in the future. It seems a little messy
to ifdef this just to save 4 bytes. Are you sure you want to do this?
prev parent reply other threads:[~2012-09-03 2:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 23:15 [U-Boot] [PATCH 1/3] disk: part_efi: parse and store partition UUID Stephen Warren
2012-08-16 23:15 ` [U-Boot] [PATCH 2/3] cmd_partuuid: add command to retrieve a partition's UUID Stephen Warren
2012-08-16 23:21 ` Stephen Warren
2012-08-17 6:46 ` Lukasz Majewski
2012-08-17 15:08 ` Stephen Warren
2012-08-17 15:21 ` Lukasz Majewski
2012-08-16 23:15 ` [U-Boot] [PATCH 3/3] tegra: enable CONFIG_CMD_PARTUUID Stephen Warren
2012-10-02 6:39 ` Simon Glass
2012-09-02 17:45 ` [U-Boot] [PATCH 1/3] disk: part_efi: parse and store partition UUID Wolfgang Denk
2012-09-03 2:06 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504410A8.3030707@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox