* [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed
@ 2012-08-28 9:56 Otavio Salvador
2012-08-28 9:56 ` [U-Boot] [PATCH v2 2/2] MX28: mx28evk: Enable SPI DMA Otavio Salvador
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Otavio Salvador @ 2012-08-28 9:56 UTC (permalink / raw)
To: u-boot
Align the SSP clock speed with oscilator to achieve higher transfer
stability.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v2:
- reword commit log to match the change description done on m28evk.
board/freescale/mx28evk/mx28evk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/mx28evk/mx28evk.c b/board/freescale/mx28evk/mx28evk.c
index 867d3c8..d782aea 100644
--- a/board/freescale/mx28evk/mx28evk.c
+++ b/board/freescale/mx28evk/mx28evk.c
@@ -49,8 +49,8 @@ int board_early_init_f(void)
/* SSP0 clock at 96MHz */
mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
- /* SSP2 clock at 96MHz */
- mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
+ /* SSP2 clock at 160MHz */
+ mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);
#ifdef CONFIG_CMD_USB
mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [U-Boot] [PATCH v2 2/2] MX28: mx28evk: Enable SPI DMA
2012-08-28 9:56 [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed Otavio Salvador
@ 2012-08-28 9:56 ` Otavio Salvador
2012-09-04 10:04 ` Stefano Babic
2012-08-28 10:18 ` [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed Marek Vasut
2012-09-04 10:04 ` Stefano Babic
2 siblings, 1 reply; 7+ messages in thread
From: Otavio Salvador @ 2012-08-28 9:56 UTC (permalink / raw)
To: u-boot
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v2:
- new patch
include/configs/mx28evk.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 8d83495..a5a98fb 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -200,6 +200,7 @@
#ifdef CONFIG_CMD_SPI
#define CONFIG_HARD_SPI
#define CONFIG_MXS_SPI
+#define CONFIG_MXS_SPI_DMA_ENABLE
#define CONFIG_SPI_HALF_DUPLEX
#define CONFIG_DEFAULT_SPI_BUS 2
#define CONFIG_DEFAULT_SPI_MODE SPI_MODE_0
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2 2/2] MX28: mx28evk: Enable SPI DMA
2012-08-28 9:56 ` [U-Boot] [PATCH v2 2/2] MX28: mx28evk: Enable SPI DMA Otavio Salvador
@ 2012-09-04 10:04 ` Stefano Babic
0 siblings, 0 replies; 7+ messages in thread
From: Stefano Babic @ 2012-09-04 10:04 UTC (permalink / raw)
To: u-boot
On 28/08/2012 11:56, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed
2012-08-28 9:56 [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed Otavio Salvador
2012-08-28 9:56 ` [U-Boot] [PATCH v2 2/2] MX28: mx28evk: Enable SPI DMA Otavio Salvador
@ 2012-08-28 10:18 ` Marek Vasut
2012-08-28 21:47 ` Otavio Salvador
2012-09-04 10:04 ` Stefano Babic
2 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2012-08-28 10:18 UTC (permalink / raw)
To: u-boot
Dear Otavio Salvador,
> Align the SSP clock speed with oscilator to achieve higher transfer
> stability.
This change is still pointless, unless you have user for this!
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> Changes in v2:
> - reword commit log to match the change description done on m28evk.
>
> board/freescale/mx28evk/mx28evk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/freescale/mx28evk/mx28evk.c
> b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644
> --- a/board/freescale/mx28evk/mx28evk.c
> +++ b/board/freescale/mx28evk/mx28evk.c
> @@ -49,8 +49,8 @@ int board_early_init_f(void)
>
> /* SSP0 clock at 96MHz */
> mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
> - /* SSP2 clock at 96MHz */
> - mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
> + /* SSP2 clock at 160MHz */
> + mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);
>
> #ifdef CONFIG_CMD_USB
> mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed
2012-08-28 10:18 ` [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed Marek Vasut
@ 2012-08-28 21:47 ` Otavio Salvador
2012-08-29 1:17 ` Marek Vasut
0 siblings, 1 reply; 7+ messages in thread
From: Otavio Salvador @ 2012-08-28 21:47 UTC (permalink / raw)
To: u-boot
On Tue, Aug 28, 2012 at 7:18 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Dear Otavio Salvador,
>
>> Align the SSP clock speed with oscilator to achieve higher transfer
>> stability.
>
> This change is still pointless, unless you have user for this!
As far as I know the SPI flash uses SSP2; so it is a user of it.
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> Changes in v2:
>> - reword commit log to match the change description done on m28evk.
>>
>> board/freescale/mx28evk/mx28evk.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/board/freescale/mx28evk/mx28evk.c
>> b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644
>> --- a/board/freescale/mx28evk/mx28evk.c
>> +++ b/board/freescale/mx28evk/mx28evk.c
>> @@ -49,8 +49,8 @@ int board_early_init_f(void)
>>
>> /* SSP0 clock at 96MHz */
>> mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
>> - /* SSP2 clock at 96MHz */
>> - mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
>> + /* SSP2 clock at 160MHz */
>> + mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);
>>
>> #ifdef CONFIG_CMD_USB
>> mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);
>
> Best regards,
> Marek Vasut
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed
2012-08-28 21:47 ` Otavio Salvador
@ 2012-08-29 1:17 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2012-08-29 1:17 UTC (permalink / raw)
To: u-boot
Dear Otavio Salvador,
> On Tue, Aug 28, 2012 at 7:18 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > Dear Otavio Salvador,
> >
> >> Align the SSP clock speed with oscilator to achieve higher transfer
> >> stability.
> >
> > This change is still pointless, unless you have user for this!
>
> As far as I know the SPI flash uses SSP2; so it is a user of it.
So, why dont you also align the default clockspeed of the spi flash attached to
ssp2 in the config file within this patch?
Lemme answer myself after taking a look ... because that's already done.
Ok,
Acked-by: Marek Vasut <marex@denx.de>
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >> Changes in v2:
> >> - reword commit log to match the change description done on m28evk.
> >>
> >> board/freescale/mx28evk/mx28evk.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/board/freescale/mx28evk/mx28evk.c
> >> b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644
> >> --- a/board/freescale/mx28evk/mx28evk.c
> >> +++ b/board/freescale/mx28evk/mx28evk.c
> >> @@ -49,8 +49,8 @@ int board_early_init_f(void)
> >>
> >> /* SSP0 clock at 96MHz */
> >> mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
> >>
> >> - /* SSP2 clock at 96MHz */
> >> - mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
> >> + /* SSP2 clock at 160MHz */
> >> + mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);
> >>
> >> #ifdef CONFIG_CMD_USB
> >>
> >> mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);
> >
> > Best regards,
> > Marek Vasut
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed
2012-08-28 9:56 [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed Otavio Salvador
2012-08-28 9:56 ` [U-Boot] [PATCH v2 2/2] MX28: mx28evk: Enable SPI DMA Otavio Salvador
2012-08-28 10:18 ` [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed Marek Vasut
@ 2012-09-04 10:04 ` Stefano Babic
2 siblings, 0 replies; 7+ messages in thread
From: Stefano Babic @ 2012-09-04 10:04 UTC (permalink / raw)
To: u-boot
On 28/08/2012 11:56, Otavio Salvador wrote:
> Align the SSP clock speed with oscilator to achieve higher transfer
> stability.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-09-04 10:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-28 9:56 [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed Otavio Salvador
2012-08-28 9:56 ` [U-Boot] [PATCH v2 2/2] MX28: mx28evk: Enable SPI DMA Otavio Salvador
2012-09-04 10:04 ` Stefano Babic
2012-08-28 10:18 ` [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed Marek Vasut
2012-08-28 21:47 ` Otavio Salvador
2012-08-29 1:17 ` Marek Vasut
2012-09-04 10:04 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox