From: Zhong Hongbo <bocui107@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [V2] disk/partition: Fix the depend for all the partitions file
Date: Tue, 04 Sep 2012 22:09:23 +0800 [thread overview]
Message-ID: <50460B93.3030109@gmail.com> (raw)
In-Reply-To: <20120902124156.D1B98203B2F@gemini.denx.de>
On 02/09/12 20:41, Wolfgang Denk wrote:
> Dear Zhong Hongbo,
>
> In message <1345075118-3131-1-git-send-email-bocui107@gmail.com> you wrote:
>> From: Zhong Hongbo <bocui107@gmail.com>
>>
>> all the patitions should depend CONFIG_PARTITIONS, no the
>> CONFIG_CMD_$(device). The device symbol may be SATA, SCSI,
>> USB, MMC, SYSTEMACE. Or else when the filesystem command be
>> enabled, But board's configure file can not include any
>> CONFIG_CMD_$(device), The u-boot will fail build. For example:
>> CONFIG_CMD_EXT2 is defined in smdk6400.h, but the boards can
>> not define any disk device. The error information of build as
>> following:
>>
>> common/cmd_ext2.c:191: undefined reference to `get_partition_info'
>> fs/ext2/libext2fs.o: In function `ext2fs_set_blk_dev':
>> fs/ext2/dev.c:44: undefined reference to `get_partition_info'
>>
>> Signed-off-by: Zhong Hongbo <bocui107@gmail.com>
>> ---
>> Change for V2:
>> - Add Signed-off-by.
>> ---
>> disk/part.c | 21 +++------------------
>> disk/part_amiga.c | 6 +-----
>> disk/part_dos.c | 7 +------
>> disk/part_efi.c | 7 +------
>> disk/part_iso.c | 7 +------
>> disk/part_mac.c | 7 +------
>> 6 files changed, 8 insertions(+), 47 deletions(-)
>
> Hm.... did you make sure that all related board config files actually
> define CONFIG_PARTITIONS ?
No, Do you think that I should add "CONFIG_PARTITIONS" to all the
boards? and try compile it?
I will do it recently.
Thanks,
hongbo
>
> I doubt so.
>
> Best regards,
>
> Wolfgang Denk
>
prev parent reply other threads:[~2012-09-04 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 23:58 [U-Boot] [V2] disk/partition: Fix the depend for all the partitions file Zhong Hongbo
2012-09-02 12:40 ` Wolfgang Denk
2012-09-04 14:13 ` Zhong Hongbo
2012-09-02 12:41 ` Wolfgang Denk
2012-09-04 14:09 ` Zhong Hongbo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50460B93.3030109@gmail.com \
--to=bocui107@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox