From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhong Hongbo Date: Tue, 04 Sep 2012 22:09:23 +0800 Subject: [U-Boot] [V2] disk/partition: Fix the depend for all the partitions file In-Reply-To: <20120902124156.D1B98203B2F@gemini.denx.de> References: <1345075118-3131-1-git-send-email-bocui107@gmail.com> <20120902124156.D1B98203B2F@gemini.denx.de> Message-ID: <50460B93.3030109@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/09/12 20:41, Wolfgang Denk wrote: > Dear Zhong Hongbo, > > In message <1345075118-3131-1-git-send-email-bocui107@gmail.com> you wrote: >> From: Zhong Hongbo >> >> all the patitions should depend CONFIG_PARTITIONS, no the >> CONFIG_CMD_$(device). The device symbol may be SATA, SCSI, >> USB, MMC, SYSTEMACE. Or else when the filesystem command be >> enabled, But board's configure file can not include any >> CONFIG_CMD_$(device), The u-boot will fail build. For example: >> CONFIG_CMD_EXT2 is defined in smdk6400.h, but the boards can >> not define any disk device. The error information of build as >> following: >> >> common/cmd_ext2.c:191: undefined reference to `get_partition_info' >> fs/ext2/libext2fs.o: In function `ext2fs_set_blk_dev': >> fs/ext2/dev.c:44: undefined reference to `get_partition_info' >> >> Signed-off-by: Zhong Hongbo >> --- >> Change for V2: >> - Add Signed-off-by. >> --- >> disk/part.c | 21 +++------------------ >> disk/part_amiga.c | 6 +----- >> disk/part_dos.c | 7 +------ >> disk/part_efi.c | 7 +------ >> disk/part_iso.c | 7 +------ >> disk/part_mac.c | 7 +------ >> 6 files changed, 8 insertions(+), 47 deletions(-) > > Hm.... did you make sure that all related board config files actually > define CONFIG_PARTITIONS ? No, Do you think that I should add "CONFIG_PARTITIONS" to all the boards? and try compile it? I will do it recently. Thanks, hongbo > > I doubt so. > > Best regards, > > Wolfgang Denk >