public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] hwconfig: Move HWCONFIG_BUFFER_SIZE into hwconfig.h
Date: Tue, 4 Sep 2012 09:16:02 -0700	[thread overview]
Message-ID: <50462942.5030200@freescale.com> (raw)
In-Reply-To: <20120902124320.B41D4203B2F@gemini.denx.de>

On 09/02/2012 05:43 AM, Wolfgang Denk wrote:
> Dear York Sun,
>
> In message <1345226412.6510.38.camel@oslab-l1> you wrote:
>> On Fri, 2012-08-17 at 12:54 -0500, Kumar Gala wrote:
>>> On Aug 15, 2012, at 7:53 PM, York Sun wrote:
>>>
>>>> Before proper environment is setup, we extract hwconfig and put it into a
>>>> buffer with size HWCONFIG_BUFFER_SIZE. We need to enlarge the buffer to
>>>> accommodate longer string. Since this macro is used in multiple files, we
>>>> move it into hwconfig.h.
>>>>
>>>> Signed-off-by: York Sun <yorksun@freescale.com>
>>>> ---
>>>>
>>>> arch/powerpc/cpu/mpc85xx/cpu_init.c           |    2 --
>>>> arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c |    2 --
>>>> arch/powerpc/cpu/mpc8xxx/ddr/options.c        |    1 -
>>>> include/hwconfig.h                            |    2 ++
>>>> 4 files changed, 2 insertions(+), 5 deletions(-)
>>>
>>> 1. I don't think HWCONFIG_BUFFER_SIZE should be getting set in include/hwconfig.h, this is unique to FSL 8xxx usage not to hwconfig
>>
>> If no one else uses this feature, I can move it to
>> arch/powerpc/include/asm/config.h. How about that?
>
> I cannot see in which way arch/powerpc/include/asm/config.h would be
> more FSL 8xxx specific ?
>

I can put it within

#if defined(CONFIG_MPC85xx) || \
     defined(CONFIG_MPC83xx) || \
     defined(CONFIG_MPC86xx)
#ednif

How about that?

York

      reply	other threads:[~2012-09-04 16:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16  0:53 [U-Boot] [PATCH] hwconfig: Move HWCONFIG_BUFFER_SIZE into hwconfig.h York Sun
2012-08-17 17:54 ` Kumar Gala
2012-08-17 18:00   ` York Sun
2012-09-02 12:43     ` Wolfgang Denk
2012-09-04 16:16       ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50462942.5030200@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox