public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] powerpc/85xx: Add P5040 processor support
Date: Thu, 6 Sep 2012 11:52:09 -0500	[thread overview]
Message-ID: <5048D4B9.7080803@freescale.com> (raw)
In-Reply-To: <1346444736-24610-4-git-send-email-timur@freescale.com>

On 08/31/2012 03:25 PM, Timur Tabi wrote:
> +	SET_PCI_LIODN_BASE(CONFIG_SYS_FSL_PCIE_COMPAT, 1, 193),
> +	SET_PCI_LIODN_BASE(CONFIG_SYS_FSL_PCIE_COMPAT, 2, 194),
> +	SET_PCI_LIODN_BASE(CONFIG_SYS_FSL_PCIE_COMPAT, 3, 195),

You're only allowing for one LIODN per PCIe controller, which defeats
the purpose of the new PCIe LIODN mechanism.

Please allocate several contiguous LIODNs per controller, set the base
to the first one, and enumerate the rest in a device tree property for
the OS to use.

-Scott

  reply	other threads:[~2012-09-06 16:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-31 20:25 [U-Boot] [PATCH 1/5] powerpc/mpc85xx: fix Unicode characters in release.S Timur Tabi
2012-08-31 20:25 ` [U-Boot] [PATCH 2/5] powerpc/85xx: introduce SET_PCI_LIODN_BASE, for setting PCI LIODNs Timur Tabi
2012-08-31 20:25 ` [U-Boot] [PATCH 3/5] powerpc/85xx: move SRIO configuration out of corenet_ds.h Timur Tabi
2012-08-31 20:25 ` [U-Boot] [PATCH 4/5] powerpc/85xx: Add P5040 processor support Timur Tabi
2012-09-06 16:52   ` Scott Wood [this message]
2012-09-10 23:00   ` [U-Boot] [u-boot-release] " Kim Phillips
2012-09-10 23:30     ` Tabi Timur-B04825
2012-09-11 15:57       ` Kim Phillips
2012-09-11 16:03         ` Timur Tabi
2012-08-31 20:25 ` [U-Boot] [PATCH 5/5] powerpc/85xx: add support for the Freescale P5040DS Superhydra reference board Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5048D4B9.7080803@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox