public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc mpc85xx: Synchronization Required for mmucsr0 spr
Date: Fri, 7 Sep 2012 13:50:21 -0500	[thread overview]
Message-ID: <504A41ED.7050606@freescale.com> (raw)
In-Reply-To: <1347020727.4539.24.camel@HRWKS7102-l.haslerrail.net>

On 09/07/2012 07:25 AM, Laurent Joye wrote:
> As explained in the PowerPC e500 Core Family Reference Manual
> (Synchronization Requirements for SPRs), an isync instruction
> is required after a mtspr mmucsr0 instruction.
> 
> Signed-off-by: Laurent Joye <laurent.joye@haslerrail.com>
> ---
>  arch/powerpc/cpu/mpc85xx/tlb.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/cpu/mpc85xx/tlb.c
> b/arch/powerpc/cpu/mpc85xx/tlb.c
> index 929f6a6..c548f67 100644
> --- a/arch/powerpc/cpu/mpc85xx/tlb.c
> +++ b/arch/powerpc/cpu/mpc85xx/tlb.c
> @@ -38,6 +38,7 @@ void invalidate_tlb(u8 tlb)
>                 mtspr(MMUCSR0, 0x4);
>         if (tlb == 1)
>                 mtspr(MMUCSR0, 0x2);
> +       asm volatile("isync");
>  }
>  
>  void init_tlbs(void)
> 

We can probably just get rid of that function.  It only affects
non-IPROT entries, of which we shouldn't have any.  As of "powerpc/85xx:
clear out TLB on boot" we shouldn't have any stale TLB1 entries from
before U-Boot took over.

-Scott

  reply	other threads:[~2012-09-07 18:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1347020643-25549-1-git-send-email-laurent.joye@haslerrail.com>
2012-09-07 12:25 ` [U-Boot] [PATCH] powerpc mpc85xx: Synchronization Required for mmucsr0 spr Laurent Joye
2012-09-07 18:50   ` Scott Wood [this message]
2012-09-07 12:52 Joye Laurent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504A41ED.7050606@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox