[U-Boot] Recent commit to env_nand.c causing saveenv to hang

[U-Boot] Recent commit to env_nand.c causing saveenv to hang

[Prabhakar Lad]

Hi Stephen,

I checked out the latest code and try flashing on DM355 for NAND boot mode,
I saw that saveenv was causing a hang. A little debugging pointed me to
this patch http://patchwork.ozlabs.org/patch/174069/ reverting this
patch saveenv
works fine.
Has this patch being tested ? Or is that I am missing out some where.

Thx,
--Prabhakar Lad

[U-Boot] Recent commit to env_nand.c causing saveenv to hang

[Stephen Warren]

On 09/07/2012 06:17 AM, Prabhakar Lad wrote:
> Hi Stephen,
> 
> I checked out the latest code and try flashing on DM355 for NAND boot mode,
> I saw that saveenv was causing a hang. A little debugging pointed me to
> this patch http://patchwork.ozlabs.org/patch/174069/ reverting this
> patch saveenv
> works fine.
> Has this patch being tested ? Or is that I am missing out some where.

Yes, I've definitely used this on the NVIDIA Tegra Harmony board.

I tested the patch on top of repo u-boot-tegra.git branch master, but
the patch ended up getting applied directly by Wolfgang to u-boot.git. I
don't think that should cause any issues though; the patch shouldn't be
dependant on anything Tegra-specific.

I just re-tested to make sure. The exact code I tested is at:
git at github.com:swarren/u-boot.git mainline_dev

Do you have any clue why it's hanging or crashing? Perhaps you can add
some debug statements to see exactly where it's happening?

[U-Boot] Recent commit to env_nand.c causing saveenv to hang

[Prabhakar Lad]

On Fri, Sep 7, 2012 at 9:35 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 09/07/2012 06:17 AM, Prabhakar Lad wrote:
>> Hi Stephen,
>>
>> I checked out the latest code and try flashing on DM355 for NAND boot mode,
>> I saw that saveenv was causing a hang. A little debugging pointed me to
>> this patch http://patchwork.ozlabs.org/patch/174069/ reverting this
>> patch saveenv
>> works fine.
>> Has this patch being tested ? Or is that I am missing out some where.
>
> Yes, I've definitely used this on the NVIDIA Tegra Harmony board.
>
> I tested the patch on top of repo u-boot-tegra.git branch master, but
> the patch ended up getting applied directly by Wolfgang to u-boot.git. I
> don't think that should cause any issues though; the patch shouldn't be
> dependant on anything Tegra-specific.
>
> I just re-tested to make sure. The exact code I tested is at:
> git at github.com:swarren/u-boot.git mainline_dev
>
> Do you have any clue why it's hanging or crashing? Perhaps you can add
> some debug statements to see exactly where it's happening?
I added some debug statements and saw that in hexport_r() function
where  memset(res, '\0', size); is done this where it hangs :(.
hope this might help.

Thanks and Regards,
--Prabhakar Lad

[U-Boot] Recent commit to env_nand.c causing saveenv to hang

[Stephen Warren]

On 09/07/2012 10:44 AM, Prabhakar Lad wrote:
> On Fri, Sep 7, 2012 at 9:35 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 09/07/2012 06:17 AM, Prabhakar Lad wrote:
>>> Hi Stephen,
>>>
>>> I checked out the latest code and try flashing on DM355 for NAND boot mode,
>>> I saw that saveenv was causing a hang. A little debugging pointed me to
>>> this patch http://patchwork.ozlabs.org/patch/174069/ reverting this
>>> patch saveenv
>>> works fine.
>>> Has this patch being tested ? Or is that I am missing out some where.
>>
>> Yes, I've definitely used this on the NVIDIA Tegra Harmony board.
>>
>> I tested the patch on top of repo u-boot-tegra.git branch master, but
>> the patch ended up getting applied directly by Wolfgang to u-boot.git. I
>> don't think that should cause any issues though; the patch shouldn't be
>> dependant on anything Tegra-specific.
>>
>> I just re-tested to make sure. The exact code I tested is at:
>> git at github.com:swarren/u-boot.git mainline_dev
>>
>> Do you have any clue why it's hanging or crashing? Perhaps you can add
>> some debug statements to see exactly where it's happening?
>
> I added some debug statements and saw that in hexport_r() function
> where  memset(res, '\0', size); is done this where it hangs :(.
> hope this might help.

For the list archives: I believe the following patch should fix this:

http://lists.denx.de/pipermail/u-boot/2012-September/133476.html

Sorry for the breakage.