public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ubifs: Fix ubifsload when using ZLIB
Date: Mon, 10 Sep 2012 11:39:45 +0200	[thread overview]
Message-ID: <504DB561.1040902@denx.de> (raw)
In-Reply-To: <1346857514-14742-1-git-send-email-veli-pekka.peltola@bluegiga.com>

On 09/05/2012 05:05 PM, Veli-Pekka Peltola wrote:
> Using ZLIB compression with UBIFS fails if last data node is not a size of
> UBIFS_BLOCK_SIZE (4096 bytes).
> 
> Easiest way to test this is trying to read a file smaller than 4k:
> => ubifsload 41000000 /etc/fstab
> Loading file '/etc/fstab' to addr 0x41000000 with size 704 (0x000002c0)...
> UBIFS error (pid 0): read_block: bad data node (block 0, inode 2506)
> UBIFS error (pid 0): do_readpage: cannot read page 0 of inode 2506, error -22
> Error reading file '/etc/fstab'
> /etc/fstab not found!
> exit not allowed from main input shell.
> =>
> 
> With this patch:
> 
> => ubifsload 41000000 /etc/fstab
> Loading file '/etc/fstab' to addr 0x41000000 with size 704 (0x000002c0)...
> Done
> =>

Thanks for this fix.

Applied to u-boot-ubi/master after minor coding style fix (line over 80
chars).

Thanks,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

      parent reply	other threads:[~2012-09-10  9:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 15:05 [U-Boot] [PATCH v2] ubifs: Fix ubifsload when using ZLIB Veli-Pekka Peltola
2012-09-07  8:00 ` Andreas Bießmann
2012-09-10  9:39 ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504DB561.1040902@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox