From: Dirk Behme <dirk.behme@de.bosch.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6qsabresd: Add basic support
Date: Tue, 11 Sep 2012 07:39:30 +0200 [thread overview]
Message-ID: <504ECE92.2030702@de.bosch.com> (raw)
In-Reply-To: <CAOMZO5DvENqre5Tzu7O5xmUTgT7vNp3TkDQqADGpqBP4EzTF_Q@mail.gmail.com>
On 11.09.2012 05:56, Fabio Estevam wrote:
> Hi Stefano,
>
> On Thu, Apr 12, 2012 at 7:52 AM, Stefano Babic <sbabic@denx.de> wrote:
>
>> This file is identical to imximage.cfg for the mx6qsabrelite board. I
>> can imagine this is derived board. Why cannot we implement it as a
>> variant of the original one ? We have several example in u-boot, for
>> example the efika (MX51), or the TAM3517 (ok, I admit I know this very
>> well because I did it...), or imx27-lite /magnesium, or....
>
> After a long time, I am returning on adding support to mx6qsabresd.
>
> I have been comparing mx6qsabrelite against mx6qsabresd and I have
> started to do as you suggested: unify the 2 boards into
> mx6qsabrelite.c.
>
> What I realize is that the differences are relevant: UART1 pin muxing,
> SDHC ports, SDHC card detect GPIO, USB Host enable port, I2C devices,
> Ethernet PHY, etc.
>
> It seems to me that the code is becoming polluted by all the ifdef's I
> need to place in order to handle both boards, and I am starting to
> think if it wouldn't be better to follow with the original approach of
> adding a board/freescale/mx6qsabresd directory.
>
> After I finish mx6qsabresd, I also plan to add one more mx6q board,
> and this would mean even more ifdefs, which would make the code even
> harder to read.
>
> Please let me know what you think.
I don't know all the boards close enough, but if we could somehow find
an unique identifier to be able to auto-detect the board type at runtime
and read this early in the boot phase, we could try to have one U-Boot
binary for different boards which configures itself correctly at runtime.
Just an idea ...
Best regards
Dirk
next prev parent reply other threads:[~2012-09-11 5:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 15:28 [U-Boot] [PATCH] mx6qsabresd: Add basic support Fabio Estevam
2012-04-11 19:49 ` Wolfgang Denk
2012-04-11 20:15 ` Fabio Estevam
2012-04-11 21:36 ` Wolfgang Denk
2012-04-13 15:56 ` Fabio Estevam
2012-04-13 16:14 ` Dirk Behme
2012-04-13 22:36 ` Fabio Estevam
2012-04-13 23:04 ` Fabio Estevam
2012-04-14 5:36 ` Dirk Behme
2012-04-14 14:41 ` stefano babic
2012-04-14 15:24 ` Fabio Estevam
2012-04-14 15:28 ` Fabio Estevam
2012-04-14 16:00 ` stefano babic
2012-04-14 20:15 ` Wolfgang Denk
2012-04-15 8:56 ` stefano babic
2012-04-14 20:14 ` Wolfgang Denk
2012-04-14 20:13 ` Wolfgang Denk
2012-04-15 9:02 ` stefano babic
2012-07-11 6:23 ` Dirk Behme
2012-07-11 8:08 ` Fabio Estevam
2012-04-12 8:23 ` Marek Vasut
2012-04-12 10:52 ` Stefano Babic
2012-09-11 3:56 ` Fabio Estevam
2012-09-11 4:27 ` stefano babic
2012-09-11 5:39 ` Dirk Behme [this message]
2012-09-11 14:43 ` Eric Nelson
2012-09-11 15:07 ` Otavio Salvador
2012-09-11 22:10 ` stefano babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504ECE92.2030702@de.bosch.com \
--to=dirk.behme@de.bosch.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox