From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Jos=E9_Miguel_Gon=E7alves?= <jose.goncalves@inov.pt>
Date: Thu, 13 Sep 2012 00:55:21 +0100
Subject: [U-Boot] [PATCH 5/7] S3C24XX: Add NAND Flash driver
In-Reply-To: <201209130145.08012.marex@denx.de>
References: <1347448523-19565-1-git-send-email-jose.goncalves@inov.pt>
	<201209122311.16702.marex@denx.de> <505117D3.1070303@inov.pt>
	<201209130145.08012.marex@denx.de>
Message-ID: <505120E9.6050102@inov.pt>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 09/13/2012 12:45 AM, Marek Vasut wrote:
> Dear Jos? Miguel Gon?alves,
>
>> Hi Marek,
>>
>> On 09/12/2012 10:11 PM, Marek Vasut wrote:
>>> Dear Jos? Miguel Gon?alves,
>>>
>>>> +
>>>> +/*
>>>> + * Hardware specific access to control-lines function
>>>> + */
>>>> +static void s3c_nand_hwcontrol(struct mtd_info *mtd, int cmd, unsigned
>>>> int ctrl) +{
>>>> +	s3c24xx_nand *const nand = s3c24xx_get_base_nand();
>>>> +	struct nand_chip *this = mtd->priv;
>>>> +
>>>> +	if (ctrl & NAND_CTRL_CHANGE) {
>>>> +		if (ctrl & NAND_CLE)
>>>> +			this->IO_ADDR_W = (void __iomem *)&nand->nfcmmd;
>>>> +		else if (ctrl & NAND_ALE)
>>>> +			this->IO_ADDR_W = (void __iomem *)&nand->nfaddr;
>>>> +		else
>>>> +			this->IO_ADDR_W = (void __iomem *)&nand->nfdata;
>>> Do you need this cast ?
>> Without it gcc gives me a warning:
>>
>> s3c24xx_nand.c:90:20: warning: assignment discards `volatile' qualifier
>> from pointer target type [enabled by default]
> Not that you need to do the assignment into the structure .... use local
> variable, no ?

Understood. I agree, it makes more sense to use a local variable to 
address the proper NAND controller register.
I will update that.

Best regards,
Jos? Gon?alves