[U-Boot] [PATCH V5 1/2] ext4fs ls load support

Rob Herring
2012-08-09T23:52:58Z

On 08/09/2012 04:50 PM, Wolfgang Denk wrote:
> Dear Uma Shankar,
>
> In message <1337961104-21198-1-git-send-email-uma.shankar@samsung.com> you wrote:
>> Signed-off-by: Uma Shankar <uma.shankar@samsung.com>
>> Signed-off-by: Manjunatha C Achar <a.manjunatha@samsung.com>
>> Signed-off-by: Iqbal Shareef <iqbal.ams@samsung.com>
>> Signed-off-by: Hakgoo Lee <goodguy.lee@samsung.com>
>> ---
>> Changes for v4:
>> - Redesigned ext2, ext4 command interface
>> - Removed ext2 folder from fs/
>> - Memory Leak issue handled
>>
>> Changes for v3:
>> - Copyright has been updated in respective files
>> - ext4fs has been made independant of ext2fs.c
>> - Fixed API namespace
>> - Removed endianness conversion API, used uboot defined API
>> for the same
>> - Fixed coding style issues
>> - Moved README.ext4 file into doc folder
>>
>> Changes for v2:
>> - Code cleanup, changed comment style
>> - camel case removed, resolved code alignment issues
>> - memory allocation logic changed, removed busybox logic
>> - Modified ext4 load to remove grub dependency (GPLv3)
>> - Introduced new Config for ext4 write
>>
>> Changes for v1:
>> - Removed checkpatch warnings and errors
>> - Moved common API's of ext2 and ext4 to one generic header file
>>
>> ---
>> Makefile | 2 +-
>> common/Makefile | 6 +
>> common/cmd_ext2.c | 219 +----------
>> common/cmd_ext4.c | 96 +++++
>> common/cmd_ext_common.c | 259 +++++++++++++
>> fs/Makefile | 5 +-
>> fs/ext2/dev.c | 131 -------
>> fs/ext2/ext2fs.c | 897 --------------------------------------------
>> fs/{ext2 => ext4}/Makefile | 8 +-
>> fs/ext4/dev.c | 145 +++++++
>> fs/ext4/ext4_common.c | 875 ++++++++++++++++++++++++++++++++++++++++++
>> fs/ext4/ext4_common.h | 63 +++
>> fs/ext4/ext4fs.c | 228 +++++++++++
>> include/ext2fs.h | 81 ----
>> include/ext4fs.h | 132 +++++++
>> include/ext_common.h | 197 ++++++++++
>> 16 files changed, 2028 insertions(+), 1316 deletions(-)
>> create mode 100644 common/cmd_ext4.c
>> create mode 100644 common/cmd_ext_common.c
>> delete mode 100644 fs/ext2/dev.c
>> delete mode 100644 fs/ext2/ext2fs.c
>> rename fs/{ext2 => ext4}/Makefile (89%)
>> create mode 100644 fs/ext4/dev.c
>> create mode 100644 fs/ext4/ext4_common.c
>> create mode 100644 fs/ext4/ext4_common.h
>> create mode 100644 fs/ext4/ext4fs.c
>> delete mode 100644 include/ext2fs.h
>> create mode 100644 include/ext4fs.h
>> create mode 100644 include/ext_common.h
>
> As this is all untested code which replaces ext2 which is in active
> use by a large number of boards I decided to put this into a separate
> branch "ext4" for now so people can easiy test it. If there are no
> problems, or the problems have been fixed in time, we can merge this
> branch around when -rc1 comes out.
>

I reported already that the prior version that ext4 has issues with
sub-directories. I don't think that has been addressed in V5. Some
directories show up fine and some don't. So it's kind of random whether
u-boot can read a /boot directory. This was after full ubuntu installs.
I'd guess a simple test with a couple of files and directories will not
show the problem.

Rob

> Hope this is OK with you.
>
> Best regards,
>
> Wolfgang Denk
>