From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/9] Tegra: T30: Add CPU (armv7) files
Date: Thu, 13 Sep 2012 14:30:03 -0600 [thread overview]
Message-ID: <5052424B.9070102@wwwdotorg.org> (raw)
In-Reply-To: <CA+m5__LxBTCjUVjqCbK5kmNYmyrJsQ+evUq3KgR5W=EiUfOfFw@mail.gmail.com>
On 09/13/2012 02:16 PM, Tom Warren wrote:
> Stephen,
>
> On Thu, Sep 13, 2012 at 1:03 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 09/12/2012 04:10 PM, Tom Warren wrote:
>>
>>> diff --git a/arch/arm/cpu/armv7/tegra30/cmd_enterrcm.c b/arch/arm/cpu/armv7/tegra30/cmd_enterrcm.c
>>
>> This whole file is definitely common with Tegra20.
>
> I'm going through your previous comments, but I'll just reply quickly
> to this one since it needs clearing up.
>
> The intent of this first series of patches for Tegra30 was just to get
> to the command prompt on T30 in the quickest way, while impacting
> Tegra20 code as little as possible. Hence, I used Tegra20 files to
> create a Tegra30 build, and as I ported it to T30 HW, I tried to
> eliminate what I could that I knew for sure was T20-specific and not
> useful. But I've made no effort to combine common files/code in this
> initial pass. I think it's much easier to understand and review these
> files as a separate SoC build, rather than having to parse
> common/combined files and code. I intend to do the
> combination/common-izing of the TegraXX builds once I have a
> reasonable T30 build in u-boot-tegra, perhaps even before I start
> porting the drivers. But this is the initial approach I took.
> Hopefully it'll be an acceptable course - I'd hate to have to
> back-track.
To be honest, it seems like the patch to add the Tegra30 deltas to the
existing Tegra20 code would be massively smaller than duplicating all of
Tegra20 as Tegra30 and applying those same changes. In the kernel, we
have both Tegra20 and Tegra30 support with run-time differentiation, and
the number of places where we have to do something different is not that
large at all. With the current patch series, there's a huge amount of
code to wade through, so spotting any places that haven't been updated
for Tegra30, or weren't intended to be updated yet, is somewhat painful.
next prev parent reply other threads:[~2012-09-13 20:30 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 22:10 [U-Boot] [PATCH 0/9] Add basic Tegra30 (T30) support Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 1/9] Tegra: T30: Add include files Tom Warren
2012-09-13 18:06 ` Tom Rini
2012-09-13 21:10 ` Tom Warren
2012-09-18 19:29 ` Simon Glass
2012-09-18 21:07 ` Tom Warren
2012-09-13 19:35 ` Stephen Warren
2012-09-13 20:51 ` Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 2/9] Tegra: T30: Add AVP (arm720t) files Tom Warren
2012-09-13 20:02 ` Stephen Warren
2012-09-13 21:00 ` Tom Warren
2012-09-13 21:47 ` Lucas Stach
2012-09-13 22:06 ` Tom Warren
2012-09-18 19:37 ` Simon Glass
2012-09-18 21:19 ` Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 3/9] Tegra: T30: Add CPU (armv7) files Tom Warren
2012-09-13 20:03 ` Stephen Warren
2012-09-13 20:16 ` Tom Warren
2012-09-13 20:30 ` Stephen Warren [this message]
2012-09-13 20:33 ` Tom Rini
2012-09-13 21:21 ` Tom Warren
2012-09-13 22:04 ` Tom Rini
2012-09-13 22:16 ` Tom Warren
2012-09-13 22:28 ` Tom Rini
2012-09-12 22:10 ` [U-Boot] [PATCH 4/9] Tegra: T30: Add common Tegra30 CPU files Tom Warren
2012-09-13 22:08 ` Stephen Warren
2012-09-18 19:40 ` Simon Glass
2012-09-12 22:10 ` [U-Boot] [PATCH 5/9] Tegra: DT: Add preliminary device tree files for T30 Cardhu Tom Warren
2012-09-13 22:14 ` Stephen Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 6/9] Tegra30: Add Cardhu board files Tom Warren
2012-09-13 22:23 ` Stephen Warren
2012-09-18 19:44 ` Simon Glass
2012-09-12 22:10 ` [U-Boot] [PATCH 7/9] Tegra30: Add config files (common and Cardhu) Tom Warren
2012-09-13 22:33 ` Stephen Warren
2012-09-13 22:45 ` Tom Rini
2012-09-13 23:38 ` Marek Vasut
2012-09-18 19:46 ` Simon Glass
2012-09-18 21:21 ` Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 8/9] Tegra30: Add common pinmux config in board_early_init_f Tom Warren
2012-09-13 22:37 ` Stephen Warren
2012-09-18 19:53 ` Simon Glass
2012-09-18 21:32 ` Tom Warren
2012-09-18 21:53 ` Stephen Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 9/9] Tegra30: Enable Cardhu build (SPL) Tom Warren
2012-09-13 18:00 ` Tom Rini
2012-09-13 20:02 ` Tom Warren
2012-09-13 22:47 ` Stephen Warren
2012-09-13 18:36 ` [U-Boot] [PATCH 0/9] Add basic Tegra30 (T30) support Stephen Warren
2012-09-13 21:04 ` Tom Rini
2012-09-13 21:25 ` Tom Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5052424B.9070102@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox