[U-Boot] [PATCH 2/9] Tegra: T30: Add AVP (arm720t) files

Tom Warren
2012-09-13T22:06:00Z

Lucas,

On Thu, Sep 13, 2012 at 2:47 PM, Lucas Stach <dev@lynxeye.de> wrote:
> Hi Tom,
>
> Am Donnerstag, den 13.09.2012, 14:00 -0700 schrieb Tom Warren:
> [...]
>>
>> >> diff --git a/arch/arm/cpu/arm720t/tegra30/spl.c b/arch/arm/cpu/arm720t/tegra30/spl.c
>> >
>> >> +void board_init_f(ulong dummy)
>> >> +{
>> >> + board_init_uart_f();
>> >> +
>> >> + /* Initialize periph GPIOs */
>> >> +#ifdef CONFIG_SPI_UART_SWITCH
>> >> + gpio_early_init_uart();
>> >> +#else
>> >> + gpio_config_uart();
>> >> +#endif
>> >
>> > Didn't we have patches to get rid of that mess and just use the same
>> > function consistently across all boards, or was that only discussed and
>> > never actually implemented?
>>
>> Someone on the list talked about a cleanup (Lucas? Thierry?), but,
>> AFAIK, that never happened, or I would have put it in tegra/next. At
>> the very least, it's not needed in Tegra30/spl.c, so I'll remove
>> it/clean it up.
>
> I did the cleanup and you in fact missed it in the last round of tegra/next.
> Patch is called "tegra20: rework UART GPIO handling" and is already
> acked-by Simon Glass.

Thanks, I see it. Now that I've re-read it, I'm remembering that I was
waiting on Allen Martin to answer Stephen's question:

" .. it looks like both SPL and non-SPL end up calling
gpio_early_init_uart(); is that duplication correct or problematic?"

I'll apply it to /next regardless, since Simon seems to think it's OK.

BTW, I'm not sure how patchwork is supposed to operate, but it appears
that the originator of the patch needs to assign it to me, mark it as
under review, etc. I don't seem to have that power for patches I
haven't written. Is that how it works for other custodians? It would
really help me keep track of Tegra patches if they could be
marked/assigned to me so I can sort on 'em. Right now, I just use a
filter with 'tegra' in it, which doesn't always find all the patches I
need to know about.

Thanks,

Tom
>
> Thanks,
> Lucas
>
>