[U-Boot] [PATCH 8/9] Tegra30: Add common pinmux config in board_early_init_f

Stephen Warren
2012-09-13T22:37:44Z

On 09/12/2012 04:10 PM, Tom Warren wrote:
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> ---
> board/nvidia/common/board.c | 27 ++++++++++++++++++++++++++-
> 1 files changed, 26 insertions(+), 1 deletions(-)

Common code:-) :-) But ...

> diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c

> +#ifdef CONFIG_TEGRA30
> +#include "../cardhu/pinmux-config-common.h"
> +#endif

Not all Tegra30 will be Cardhu...

Given this is really board-specific, shouldn't the following be an empty
weak definition:

> +/*
> + * Routine: pinmux_init
> + * Description: Do individual peripheral pinmux configs
> + */
> +static void pinmux_init(void)
> +{
> +#if defined(CONFIG_TEGRA30)
> + pinmux_config_table(tegra3_pinmux_common,
> + ARRAY_SIZE(tegra3_pinmux_common));
> +
> + pinmux_config_table(unused_pins_lowpower,
> + ARRAY_SIZE(unused_pins_lowpower));
> +#endif
> +}

... and the function be overridden in board files as needed?

If we are moving to a model of a single function that sets up the entire
pin mux at boot (which seems fine to me, and could eventually be driven
by DT if it happened late enough), then it seems like we wouldn't need
e.g. pin_mux_mmc() or pin_mux_usb() any more.