[U-Boot] [PATCH 3/9] Tegra: T30: Add CPU (armv7) files

Tom Warren
2012-09-13T20:16:06Z

Stephen,

On Thu, Sep 13, 2012 at 1:03 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 09/12/2012 04:10 PM, Tom Warren wrote:
>
>> diff --git a/arch/arm/cpu/armv7/tegra30/cmd_enterrcm.c b/arch/arm/cpu/armv7/tegra30/cmd_enterrcm.c
>
> This whole file is definitely common with Tegra20.

I'm going through your previous comments, but I'll just reply quickly
to this one since it needs clearing up.

The intent of this first series of patches for Tegra30 was just to get
to the command prompt on T30 in the quickest way, while impacting
Tegra20 code as little as possible. Hence, I used Tegra20 files to
create a Tegra30 build, and as I ported it to T30 HW, I tried to
eliminate what I could that I knew for sure was T20-specific and not
useful. But I've made no effort to combine common files/code in this
initial pass. I think it's much easier to understand and review these
files as a separate SoC build, rather than having to parse
common/combined files and code. I intend to do the
combination/common-izing of the TegraXX builds once I have a
reasonable T30 build in u-boot-tegra, perhaps even before I start
porting the drivers. But this is the initial approach I took.
Hopefully it'll be an acceptable course - I'd hate to have to
back-track.

Thanks for the thorough review,

Tom