From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/9] Tegra30: Add common pinmux config in board_early_init_f
Date: Thu, 13 Sep 2012 16:37:44 -0600 [thread overview]
Message-ID: <50526038.9040506@wwwdotorg.org> (raw)
In-Reply-To: <1347487855-27077-9-git-send-email-twarren@nvidia.com>
On 09/12/2012 04:10 PM, Tom Warren wrote:
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> ---
> board/nvidia/common/board.c | 27 ++++++++++++++++++++++++++-
> 1 files changed, 26 insertions(+), 1 deletions(-)
Common code:-) :-) But ...
> diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c
> +#ifdef CONFIG_TEGRA30
> +#include "../cardhu/pinmux-config-common.h"
> +#endif
Not all Tegra30 will be Cardhu...
Given this is really board-specific, shouldn't the following be an empty
weak definition:
> +/*
> + * Routine: pinmux_init
> + * Description: Do individual peripheral pinmux configs
> + */
> +static void pinmux_init(void)
> +{
> +#if defined(CONFIG_TEGRA30)
> + pinmux_config_table(tegra3_pinmux_common,
> + ARRAY_SIZE(tegra3_pinmux_common));
> +
> + pinmux_config_table(unused_pins_lowpower,
> + ARRAY_SIZE(unused_pins_lowpower));
> +#endif
> +}
... and the function be overridden in board files as needed?
If we are moving to a model of a single function that sets up the entire
pin mux at boot (which seems fine to me, and could eventually be driven
by DT if it happened late enough), then it seems like we wouldn't need
e.g. pin_mux_mmc() or pin_mux_usb() any more.
next prev parent reply other threads:[~2012-09-13 22:37 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 22:10 [U-Boot] [PATCH 0/9] Add basic Tegra30 (T30) support Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 1/9] Tegra: T30: Add include files Tom Warren
2012-09-13 18:06 ` Tom Rini
2012-09-13 21:10 ` Tom Warren
2012-09-18 19:29 ` Simon Glass
2012-09-18 21:07 ` Tom Warren
2012-09-13 19:35 ` Stephen Warren
2012-09-13 20:51 ` Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 2/9] Tegra: T30: Add AVP (arm720t) files Tom Warren
2012-09-13 20:02 ` Stephen Warren
2012-09-13 21:00 ` Tom Warren
2012-09-13 21:47 ` Lucas Stach
2012-09-13 22:06 ` Tom Warren
2012-09-18 19:37 ` Simon Glass
2012-09-18 21:19 ` Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 3/9] Tegra: T30: Add CPU (armv7) files Tom Warren
2012-09-13 20:03 ` Stephen Warren
2012-09-13 20:16 ` Tom Warren
2012-09-13 20:30 ` Stephen Warren
2012-09-13 20:33 ` Tom Rini
2012-09-13 21:21 ` Tom Warren
2012-09-13 22:04 ` Tom Rini
2012-09-13 22:16 ` Tom Warren
2012-09-13 22:28 ` Tom Rini
2012-09-12 22:10 ` [U-Boot] [PATCH 4/9] Tegra: T30: Add common Tegra30 CPU files Tom Warren
2012-09-13 22:08 ` Stephen Warren
2012-09-18 19:40 ` Simon Glass
2012-09-12 22:10 ` [U-Boot] [PATCH 5/9] Tegra: DT: Add preliminary device tree files for T30 Cardhu Tom Warren
2012-09-13 22:14 ` Stephen Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 6/9] Tegra30: Add Cardhu board files Tom Warren
2012-09-13 22:23 ` Stephen Warren
2012-09-18 19:44 ` Simon Glass
2012-09-12 22:10 ` [U-Boot] [PATCH 7/9] Tegra30: Add config files (common and Cardhu) Tom Warren
2012-09-13 22:33 ` Stephen Warren
2012-09-13 22:45 ` Tom Rini
2012-09-13 23:38 ` Marek Vasut
2012-09-18 19:46 ` Simon Glass
2012-09-18 21:21 ` Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 8/9] Tegra30: Add common pinmux config in board_early_init_f Tom Warren
2012-09-13 22:37 ` Stephen Warren [this message]
2012-09-18 19:53 ` Simon Glass
2012-09-18 21:32 ` Tom Warren
2012-09-18 21:53 ` Stephen Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 9/9] Tegra30: Enable Cardhu build (SPL) Tom Warren
2012-09-13 18:00 ` Tom Rini
2012-09-13 20:02 ` Tom Warren
2012-09-13 22:47 ` Stephen Warren
2012-09-13 18:36 ` [U-Boot] [PATCH 0/9] Add basic Tegra30 (T30) support Stephen Warren
2012-09-13 21:04 ` Tom Rini
2012-09-13 21:25 ` Tom Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50526038.9040506@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox