[U-Boot] [PATCH 7/9] Tegra30: Add config files (common and Cardhu)

Stephen Warren
2012-09-13T22:33:06Z

On 09/12/2012 04:10 PM, Tom Warren wrote:

> diff --git a/include/configs/tegra30-common.h b/include/configs/tegra30-common.h

> +/*
> + * QUOTE(m) will evaluate to a string version of the value of the macro m
> + * passed in. The extra level of indirection here is to first evaluate the
> + * macro m before applying the quoting operator.
> + */
> +#define QUOTE_(m) #m
> +#define QUOTE(m) QUOTE_(m)

Seems like a good candidate for a common header (not Tegra-common, but
across all of U-Boot).

> +#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600,\
> + 115200}

IIRC, that's the default now and can be removed. There may be other
variables the comment applies to - Tom Rini would know better since he
pointed them out in my RPi patches.

> +#define CONFIG_SYS_LOAD_ADDR (0x80A00800) /* default */

Hmmm. I notice that both here and the equivalent Tegra20 file, we define
both CONFIG_LOADADDR and CONFIG_SYS_LOAD_ADDR. Should we actually be
defining both, and with different values (is one unused?).