[U-Boot] [PATCH 7/9] Tegra30: Add config files (common and Cardhu)

Marek Vasut
2012-09-13T23:38:57Z

Dear Tom Rini,

> On 09/13/2012 03:33 PM, Stephen Warren wrote:
> > On 09/12/2012 04:10 PM, Tom Warren wrote:
> >> diff --git a/include/configs/tegra30-common.h
> >> b/include/configs/tegra30-common.h
> >>
> >> +/*
> >> + * QUOTE(m) will evaluate to a string version of the value of the macro
> >> m + * passed in. The extra level of indirection here is to first
> >> evaluate the + * macro m before applying the quoting operator.
> >> + */
> >> +#define QUOTE_(m) #m
> >> +#define QUOTE(m) QUOTE_(m)
> >
> > Seems like a good candidate for a common header (not Tegra-common, but
> > across all of U-Boot).
>
> This is __stringify() that Marek needs to address Wolfgang's comment on
> still, iirc.

I need to roll out the stringify patches ... the issues should be fixed.

> >> +#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600,\
> >> + 115200}
> >
> > IIRC, that's the default now and can be removed. There may be other
> > variables the comment applies to - Tom Rini would know better since he
> > pointed them out in my RPi patches.
>
> That and the hush prompt one if it's there need to go.

Best regards,
Marek Vasut